From: muller@ics.u-strasbg.fr
To: Andrew Cagney <ac131313@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc] FRAME_FP() -> get_frame_base()
Date: Sun, 24 Nov 2002 15:06:00 -0000 [thread overview]
Message-ID: <3.0.6.32.20021125000652.00c29e60@ics.u-strasbg.fr> (raw)
In-Reply-To: <3DE11E83.2050809@redhat.com>
At 13:46 24/11/2002 -0500, you wrote:
>> 2002-11-19 Andrew Cagney <ac131313@redhat.com>
>>
>> * frame.h (FRAME_FP): Delete macro.
>> (get_frame_base): New function declaration.
>> * frame.c (get_frame_base): New function.
>> (get_frame_id): Use ->frame.
>> (frame_find_by_id): Rewrite to use get_frame_id.
>> * blockframe.c: Use get_frame_base instead of FRAME_FP.
>> * cris-tdep.c, d10v-tdep.c, findvar.c, h8500-tdep.c: Ditto.
>> * hppa-tdep.c, i386-tdep.c, infcmd.c, infrun.c: Ditto.
>> * m68hc11-tdep.c, m68k-tdep.c, mcore-tdep.c, mips-tdep.c: Ditto.
>> * mn10200-tdep.c, mn10300-tdep.c, rs6000-tdep.c: Ditto.
>> * sh-tdep.c, sparc-tdep.c, stack.c, tracepoint.c: Ditto.
>> * v850-tdep.c, valops.c, z8k-tdep.c: Ditto.
>>
>I've checked this in.
Andrew, you forgot varobj.c file
I committed this as obvious fix.
2002-11-24 Pierre Muller <muller@ics.u-strasbg.fr>
* varobj.c (find_frame_addr_in_frame_chain):
Use get_frame_base instead of FRAME_FP,
obvious fix.
$ cvs diff -u -p varobj.c
Index: varobj.c
===================================================================
RCS file: /cvs/src/src/gdb/varobj.c,v
retrieving revision 1.35
diff -u -p -r1.35 varobj.c
--- varobj.c 24 Nov 2002 14:16:38 -0000 1.35
+++ varobj.c 24 Nov 2002 23:02:22 -0000
@@ -412,7 +412,7 @@ find_frame_addr_in_frame_chain (CORE_ADD
frame = get_prev_frame (frame);
if (frame == NULL)
return NULL;
- if (FRAME_FP (frame) == frame_addr)
+ if (get_frame_base (frame) == frame_addr)
return frame;
}
}
prev parent reply other threads:[~2002-11-24 23:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-19 11:55 Andrew Cagney
2002-11-19 21:56 ` Eli Zaretskii
2002-11-20 8:26 ` Andrew Cagney
2002-11-20 13:38 ` Kevin Buettner
2002-11-20 18:26 ` Andrew Cagney
2002-11-22 17:32 ` Andrew Cagney
2002-11-24 10:46 ` Andrew Cagney
2002-11-24 15:06 ` muller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3.0.6.32.20021125000652.00c29e60@ics.u-strasbg.fr \
--to=muller@ics.u-strasbg.fr \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox