From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24045 invoked by alias); 24 Nov 2002 23:06:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24038 invoked from network); 24 Nov 2002 23:06:51 -0000 Received: from unknown (HELO factorix.sdv.fr) (212.95.66.10) by sources.redhat.com with SMTP; 24 Nov 2002 23:06:51 -0000 Received: from pc-muller (ip-76-93.evc.net [212.95.76.93]) by factorix.sdv.fr (Postfix) with SMTP id 6F87BDDD3F; Mon, 25 Nov 2002 00:06:50 +0100 (CET) Message-Id: <3.0.6.32.20021125000652.00c29e60@ics.u-strasbg.fr> X-Sender: muller@ics.u-strasbg.fr Date: Sun, 24 Nov 2002 15:06:00 -0000 To: Andrew Cagney , gdb-patches@sources.redhat.com From: muller@ics.u-strasbg.fr Subject: Re: [patch/rfc] FRAME_FP() -> get_frame_base() In-Reply-To: <3DE11E83.2050809@redhat.com> References: <3DDA9741.4050001@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" X-SW-Source: 2002-11/txt/msg00593.txt.bz2 At 13:46 24/11/2002 -0500, you wrote: >> 2002-11-19 Andrew Cagney >> >> * frame.h (FRAME_FP): Delete macro. >> (get_frame_base): New function declaration. >> * frame.c (get_frame_base): New function. >> (get_frame_id): Use ->frame. >> (frame_find_by_id): Rewrite to use get_frame_id. >> * blockframe.c: Use get_frame_base instead of FRAME_FP. >> * cris-tdep.c, d10v-tdep.c, findvar.c, h8500-tdep.c: Ditto. >> * hppa-tdep.c, i386-tdep.c, infcmd.c, infrun.c: Ditto. >> * m68hc11-tdep.c, m68k-tdep.c, mcore-tdep.c, mips-tdep.c: Ditto. >> * mn10200-tdep.c, mn10300-tdep.c, rs6000-tdep.c: Ditto. >> * sh-tdep.c, sparc-tdep.c, stack.c, tracepoint.c: Ditto. >> * v850-tdep.c, valops.c, z8k-tdep.c: Ditto. >> >I've checked this in. Andrew, you forgot varobj.c file I committed this as obvious fix. 2002-11-24 Pierre Muller * varobj.c (find_frame_addr_in_frame_chain): Use get_frame_base instead of FRAME_FP, obvious fix. $ cvs diff -u -p varobj.c Index: varobj.c =================================================================== RCS file: /cvs/src/src/gdb/varobj.c,v retrieving revision 1.35 diff -u -p -r1.35 varobj.c --- varobj.c 24 Nov 2002 14:16:38 -0000 1.35 +++ varobj.c 24 Nov 2002 23:02:22 -0000 @@ -412,7 +412,7 @@ find_frame_addr_in_frame_chain (CORE_ADD frame = get_prev_frame (frame); if (frame == NULL) return NULL; - if (FRAME_FP (frame) == frame_addr) + if (get_frame_base (frame) == frame_addr) return frame; } }