From: Simon Marchi <simark@simark.ca>
To: John Baldwin <jhb@FreeBSD.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 0/6] Add a new 'info proc files' command
Date: Sun, 16 Sep 2018 02:34:00 -0000 [thread overview]
Message-ID: <2ef5236e-0b21-b669-6759-d4441a3e744c@simark.ca> (raw)
In-Reply-To: <20180912233707.43492-1-jhb@FreeBSD.org>
On 2018-09-12 7:37 p.m., John Baldwin wrote:
> This should include most of the suggested documentation fixes from the
> first series. It also adds an additional patch that attempts to tidy up
> some of the other "info proc" documentation. One change I haven't made
> (wasn't sure if it was still desired) was if we wanted to replace the
> specific annotations on individual 'info proc' subcommands about which
> OS's supported those commands with a single, more general statement that
> commands may only be supported on a subset of systems supported by GDB.
>
> I've moved more of the shared code for generating the 'info proc files'
> output to fbsd-tdep.c.
>
> One open question still from the first series is if GDB can assume the
> presence of routines like 'inet_ntoa' and 'inet_ntop' for formatting
> IPv4 and IPv6 addresses. It seems GDB does assume the presence of
> newer routines (e.g. getaddrinfo()) on POSIX systems in other places
> (e.g. ser-tcp.c), though in those places we use different APIs for
> Win32.
There seems to be a gnulib module for that:
https://www.gnu.org/software/gnulib/manual/html_node/inet_005fntop.html
There is a page for inet_ntoa too:
https://www.gnu.org/software/gnulib/manual/html_node/inet_005fntoa.html
but there is no gnulib module for it. Probably because we can always
use inet_ntop instead?
Using that would be preferable to implementing it ourself, if it does
what we need.
Simon
next prev parent reply other threads:[~2018-09-16 2:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 23:37 John Baldwin
2018-09-12 23:37 ` [PATCH v2 6/6] Make the "info proc" documentation more consistent John Baldwin
2018-09-13 13:40 ` Eli Zaretskii
2018-09-12 23:37 ` [PATCH v2 2/6] Add a new 'info proc files' subcommand of 'info proc' John Baldwin
2018-09-12 23:37 ` [PATCH v2 1/6] Use KF_PATH to verify the size of a struct kinfo_file John Baldwin
2018-09-12 23:37 ` [PATCH v2 3/6] Add support for 'info proc files' on FreeBSD core dumps John Baldwin
2018-09-16 2:27 ` Simon Marchi
2018-09-17 16:54 ` John Baldwin
2018-09-12 23:37 ` [PATCH v2 5/6] Document the 'info proc files' command John Baldwin
2018-09-13 13:39 ` Eli Zaretskii
2018-09-12 23:43 ` [PATCH v2 4/6] Support 'info proc files' on live FreeBSD processes John Baldwin
2018-09-16 2:34 ` Simon Marchi [this message]
2018-09-17 16:59 ` [PATCH v2 0/6] Add a new 'info proc files' command John Baldwin
2018-09-17 17:17 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ef5236e-0b21-b669-6759-d4441a3e744c@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox