From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58771 invoked by alias); 16 Sep 2018 02:34:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58735 invoked by uid 89); 16 Sep 2018 02:34:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_SHORT,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 16 Sep 2018 02:34:28 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2367D1E16B; Sat, 15 Sep 2018 22:34:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1537065266; bh=OWgrpUQfQv0MC+G3PZYIcj+NAipJjUTva/ZJV/qFO/M=; h=Subject:To:References:From:Date:In-Reply-To:From; b=BMZUNqcab0cGYoDEsNdsTBBxzFmxGRZoUfCdkTwoiX91STA359SRJdiYpwOw49/FB ud28jqxcyEsjxBaIHFD9/0Z2giworuG6SjEGgSMEykt+dKzKvpyacKAbfXpQr3Kr7x epH0MHCYlPRpHGCj/A3KfPDy/5t8XgyS8vklfPrs= Subject: Re: [PATCH v2 0/6] Add a new 'info proc files' command To: John Baldwin , gdb-patches@sourceware.org References: <20180912233707.43492-1-jhb@FreeBSD.org> From: Simon Marchi Message-ID: <2ef5236e-0b21-b669-6759-d4441a3e744c@simark.ca> Date: Sun, 16 Sep 2018 02:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180912233707.43492-1-jhb@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-09/txt/msg00518.txt.bz2 On 2018-09-12 7:37 p.m., John Baldwin wrote: > This should include most of the suggested documentation fixes from the > first series. It also adds an additional patch that attempts to tidy up > some of the other "info proc" documentation. One change I haven't made > (wasn't sure if it was still desired) was if we wanted to replace the > specific annotations on individual 'info proc' subcommands about which > OS's supported those commands with a single, more general statement that > commands may only be supported on a subset of systems supported by GDB. > > I've moved more of the shared code for generating the 'info proc files' > output to fbsd-tdep.c. > > One open question still from the first series is if GDB can assume the > presence of routines like 'inet_ntoa' and 'inet_ntop' for formatting > IPv4 and IPv6 addresses. It seems GDB does assume the presence of > newer routines (e.g. getaddrinfo()) on POSIX systems in other places > (e.g. ser-tcp.c), though in those places we use different APIs for > Win32. There seems to be a gnulib module for that: https://www.gnu.org/software/gnulib/manual/html_node/inet_005fntop.html There is a page for inet_ntoa too: https://www.gnu.org/software/gnulib/manual/html_node/inet_005fntoa.html but there is no gnulib module for it. Probably because we can always use inet_ntop instead? Using that would be preferable to implementing it ourself, if it does what we need. Simon