From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/symtab] Handle DW_TAG_type_unit in process_psymtab_comp_unit
Date: Fri, 5 Feb 2021 18:17:50 +0100 [thread overview]
Message-ID: <2d724969-e1af-84bb-8623-8f7ba2ffe33a@suse.de> (raw)
In-Reply-To: <87ft2a4gsu.fsf@tromey.com>
On 2/5/21 5:31 PM, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>
> Tom> 2021-02-05 Tom de Vries <tdevries@suse.de>
>
> Tom> PR symtab/27333
> Tom> * dwarf2/read.c (process_psymtab_comp_unit): Handle DW_TAG_type_unit.
>
> Looks good.
>
> Tom> default:
> Tom> abort ();
>
> asserts are really for internal consistency checks, if this is using one
> for data validation, then that's bad.
Yeah, I'm not sure. It could be that unhandled units are supposed to be
blocked earlier, in which case this really is an internal consistency check.
Thanks,
- Tom
prev parent reply other threads:[~2021-02-05 17:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 12:29 Tom de Vries
2021-02-05 16:31 ` Tom Tromey
2021-02-05 17:17 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d724969-e1af-84bb-8623-8f7ba2ffe33a@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox