From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id itioAcN9HWBRJgAAWB0awg (envelope-from ) for ; Fri, 05 Feb 2021 12:17:55 -0500 Received: by simark.ca (Postfix, from userid 112) id EBE401EFCB; Fri, 5 Feb 2021 12:17:54 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,RDNS_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 879E41EF7A for ; Fri, 5 Feb 2021 12:17:54 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C5E2E3857C4E; Fri, 5 Feb 2021 17:17:53 +0000 (GMT) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id A9CD53857C4E for ; Fri, 5 Feb 2021 17:17:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A9CD53857C4E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C45C9AC97; Fri, 5 Feb 2021 17:17:50 +0000 (UTC) Subject: Re: [PATCH][gdb/symtab] Handle DW_TAG_type_unit in process_psymtab_comp_unit To: Tom Tromey References: <20210205122917.GA19309@delia> <87ft2a4gsu.fsf@tromey.com> From: Tom de Vries Message-ID: <2d724969-e1af-84bb-8623-8f7ba2ffe33a@suse.de> Date: Fri, 5 Feb 2021 18:17:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <87ft2a4gsu.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2/5/21 5:31 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> 2021-02-05 Tom de Vries > > Tom> PR symtab/27333 > Tom> * dwarf2/read.c (process_psymtab_comp_unit): Handle DW_TAG_type_unit. > > Looks good. > > Tom> default: > Tom> abort (); > > asserts are really for internal consistency checks, if this is using one > for data validation, then that's bad. Yeah, I'm not sure. It could be that unhandled units are supposed to be blocked earlier, in which case this really is an internal consistency check. Thanks, - Tom