Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH] Change Ada catchpoints to be bp_catchpoint
Date: Wed, 10 Jul 2019 17:17:00 -0000	[thread overview]
Message-ID: <2ccbe710-fdcb-d1c0-8a87-f4b6a47843eb@redhat.com> (raw)
In-Reply-To: <20190710170635.19023-1-tromey@adacore.com>

On 7/10/19 6:06 PM, Tom Tromey wrote:
> Like Pedro's earlier patches to change catchpoint to be of type
> bp_catchpoint, this changes the Ada catchpoints to follow.
> 

Thanks, LGTM, FWIW.

Might want to add an is_ada_exception_catchpoint routine
or some such and use it in print_one_breakpoint_location and
print_one_breakpoint where is_exception_catchpoint is used,
so that "maint info breakpoints" shows these catchpoints' locations.

Thanks,
Pedro Alves


  reply	other threads:[~2019-07-10 17:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-10 17:06 Tom Tromey
2019-07-10 17:17 ` Pedro Alves [this message]
2019-07-10 20:51   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ccbe710-fdcb-d1c0-8a87-f4b6a47843eb@redhat.com \
    --to=palves@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox