From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91598 invoked by alias); 10 Jul 2019 17:17:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91589 invoked by uid 89); 10 Jul 2019 17:17:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Spam-Relays-External:209.85.221.65, H*RU:209.85.221.65 X-HELO: mail-wr1-f65.google.com Received: from mail-wr1-f65.google.com (HELO mail-wr1-f65.google.com) (209.85.221.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Jul 2019 17:17:43 +0000 Received: by mail-wr1-f65.google.com with SMTP id a10so3288825wrp.9 for ; Wed, 10 Jul 2019 10:17:42 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id n9sm3209148wrp.54.2019.07.10.10.17.40 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 10 Jul 2019 10:17:40 -0700 (PDT) Subject: Re: [PATCH] Change Ada catchpoints to be bp_catchpoint To: Tom Tromey , gdb-patches@sourceware.org References: <20190710170635.19023-1-tromey@adacore.com> Cc: Joel Brobecker From: Pedro Alves Message-ID: <2ccbe710-fdcb-d1c0-8a87-f4b6a47843eb@redhat.com> Date: Wed, 10 Jul 2019 17:17:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190710170635.19023-1-tromey@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-07/txt/msg00273.txt.bz2 On 7/10/19 6:06 PM, Tom Tromey wrote: > Like Pedro's earlier patches to change catchpoint to be of type > bp_catchpoint, this changes the Ada catchpoints to follow. > Thanks, LGTM, FWIW. Might want to add an is_ada_exception_catchpoint routine or some such and use it in print_one_breakpoint_location and print_one_breakpoint where is_exception_catchpoint is used, so that "maint info breakpoints" shows these catchpoints' locations. Thanks, Pedro Alves