From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA v2 2/6] Handle alignof and _Alignof
Date: Mon, 30 Apr 2018 17:17:00 -0000 [thread overview]
Message-ID: <2b06093d-1e53-139b-a714-d9a5f19a91af@redhat.com> (raw)
In-Reply-To: <87efiw4p1n.fsf@tromey.com>
On 04/30/2018 05:49 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> This looks good to me. A few comments on additional tests below,
> Pedro> but there's no need for another round of review for those.
>
> This patch will need another review since I added some new stuff.
Looks good, thanks.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-04-30 17:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 14:01 [RFA v2 0/6] Type alignment Tom Tromey
2018-04-27 14:01 ` [RFA v2 2/6] Handle alignof and _Alignof Tom Tromey
2018-04-27 14:19 ` Eli Zaretskii
2018-04-27 18:47 ` Pedro Alves
2018-04-27 20:55 ` Tom Tromey
2018-04-27 20:59 ` Tom Tromey
2018-04-30 16:50 ` Tom Tromey
2018-04-30 17:17 ` Pedro Alves [this message]
2018-04-27 14:01 ` [RFA v2 3/6] Reindent type_object_getset in py-type.c Tom Tromey
2018-04-27 18:47 ` Pedro Alves
2018-04-27 20:39 ` Tom Tromey
2018-04-27 14:01 ` [RFA v2 1/6] Add initial type alignment support Tom Tromey
2018-04-27 18:46 ` Pedro Alves
2018-04-27 14:01 ` [RFA v2 4/6] Expose type alignment on gdb.Type Tom Tromey
2018-04-27 14:18 ` Eli Zaretskii
2018-04-27 18:47 ` Pedro Alves
2018-04-27 20:41 ` Tom Tromey
2018-04-27 14:01 ` [RFA v2 5/6] Remove rust_type_alignment Tom Tromey
2018-04-27 14:01 ` [RFA v2 6/6] Remove long_long_align_bit gdbarch attribute Tom Tromey
2018-04-27 18:47 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b06093d-1e53-139b-a714-d9a5f19a91af@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox