From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-146965-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 53152 invoked by alias); 30 Apr 2018 17:17:40 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 53126 invoked by uid 89); 30 Apr 2018 17:17:39 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Apr 2018 17:17:38 +0000
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 410C2F95CC;	Mon, 30 Apr 2018 17:17:37 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id BD04B2024CA4;	Mon, 30 Apr 2018 17:17:36 +0000 (UTC)
Subject: Re: [RFA v2 2/6] Handle alignof and _Alignof
To: Tom Tromey <tom@tromey.com>
References: <20180427140139.7957-1-tom@tromey.com> <20180427140139.7957-3-tom@tromey.com> <2acfa770-0ec2-b675-a139-f350aa059da0@redhat.com> <87efiw4p1n.fsf@tromey.com>
Cc: gdb-patches@sourceware.org
From: Pedro Alves <palves@redhat.com>
Message-ID: <2b06093d-1e53-139b-a714-d9a5f19a91af@redhat.com>
Date: Mon, 30 Apr 2018 17:17:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <87efiw4p1n.fsf@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-04/txt/msg00657.txt.bz2

On 04/30/2018 05:49 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
> 
> Pedro> This looks good to me.  A few comments on additional tests below,
> Pedro> but there's no need for another round of review for those.
> 
> This patch will need another review since I added some new stuff.

Looks good, thanks.

Thanks,
Pedro Alves