Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Peter Bergner <bergner@vnet.ibm.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: gdb-patches@sourceware.org, Alan Modra <amodra@gmail.com>,
	       Pedro Alves <palves@redhat.com>,
	Ulrich Weigand <uweigand@de.ibm.com>,
	       Eli Zaretskii <eliz@gnu.org>,
	Nick Clifton <nickc@redhat.com>,
	       binutils <binutils@sourceware.org>
Subject: Re: [PATCH, updated] Add support for setting disassembler-options in GDB for POWER, ARM and S390
Date: Mon, 13 Feb 2017 17:08:00 -0000	[thread overview]
Message-ID: <2a9aaef6-7ead-a375-b9e7-b72429742c96@vnet.ibm.com> (raw)
In-Reply-To: <867f4uccky.fsf@gmail.com>

One additional question for you.  In the unpatched sources,
opcodes/arm-dis.c seems to prefer GCC register set names via:

   /* Default to GCC register name set.  */
   static unsigned int regname_selected = 1;

...while gdb/arm-tdep.c seems to want STD register set names via:

   /* Disassembly style to use. Default to "std" register names.  */
   static const char *disassembly_style;

...and...

   /* Sync the opcode insn printer with our register viewer.  */
   parse_arm_disassembler_option ("reg-names-std");

...and...

       /* When we find the default names, tell the disassembler to use
          them.  */
       if (!strcmp (setname, "std"))
         {
           disassembly_style = setname;
           set_arm_regname_option (i);
         }

The way this is coded, reg-names-gcc will be used as the default when
we disassemble arm instructions using objdump, while GDB will default
to using reg-names-std.  Is this intentional?

Peter


  parent reply	other threads:[~2017-02-13 17:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-08 21:03 Peter Bergner
2017-02-13 15:53 ` Yao Qi
2017-02-13 16:31   ` Peter Bergner
2017-02-13 16:58   ` Pedro Alves
2017-02-13 17:32     ` Peter Bergner
2017-02-14 17:21     ` Yao Qi
2017-02-14 17:35       ` Pedro Alves
2017-02-13 17:08   ` Peter Bergner [this message]
2017-02-13 18:48   ` Peter Bergner
2017-02-14 20:01     ` Pedro Alves
2017-02-15 23:14       ` Peter Bergner
2017-02-15 23:48         ` Alan Modra
2017-02-16  0:21         ` Pedro Alves
2017-02-16  1:59           ` Peter Bergner
2017-02-16  2:09             ` Pedro Alves
2017-02-13 18:52 ` Peter Bergner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a9aaef6-7ead-a375-b9e7-b72429742c96@vnet.ibm.com \
    --to=bergner@vnet.ibm.com \
    --cc=amodra@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=nickc@redhat.com \
    --cc=palves@redhat.com \
    --cc=qiyaoltc@gmail.com \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox