Re: [PATCH 0/4] Remove some bfd_boolean uses

[Guinevere Larsen <guinevere@redhat.com>]

On 3/7/26 3:20 PM, Tom Tromey wrote:
> I saw some recent commits removing uses of bfd_boolean from the tree.
> This series removes the remaining uses from gdb as well, and then
> arranges to poison the identifier using the BFD-supplied approach.
>
> Signed-off-by: Tom Tromey <tom@tromey.com>
> ---

Hi Tom!

I looked over this series and everything looks ok to me. I have sent a 
nitpick suggestion on patch 3, but otherwise I think this looks nice

Reviewed-By: Guinevere Larsen <guinevere@redhat.com>

> Tom Tromey (4):
>        Use bool, not bfd_boolean
>        Don't use BFD TRUE/FALSE constants
>        Drop use of bfd_boolean from findcmd.c
>        Poison bfd_boolean
>
>   gdb/arc-linux-tdep.c              |  6 +++---
>   gdb/compile/compile-object-load.c |  4 ++--
>   gdb/defs.h                        |  2 ++
>   gdb/elfread.c                     |  2 +-
>   gdb/findcmd.c                     | 33 +++++++++++++--------------------
>   gdb/ft32-tdep.c                   |  6 +++---
>   gdb/machoread.c                   |  4 ++--
>   7 files changed, 26 insertions(+), 31 deletions(-)
> ---
> base-commit: a00fddb175ff5cb9edef18beedfba38fc6fc6017
> change-id: 20260307-no-bfd-boolean-1c8cbdbf2849
>
> Best regards,


-- 
Cheers,
Guinevere Larsen
it/its
she/her (deprecated)