From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Odr0BejadWqw1xAAWB0awg (envelope-from ) for ; Fri, 07 Aug 2026 09:17:28 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GpyHPV32; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id F35E71E09B; Fri, 07 Aug 2026 09:17:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 88F7F1E09B for ; Fri, 07 Aug 2026 09:17:27 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C577C4BB58EB for ; Fri, 7 Aug 2026 13:17:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C577C4BB58EB Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GpyHPV32 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 681B44BB58B2 for ; Fri, 7 Aug 2026 12:55:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 681B44BB58B2 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 681B44BB58B2 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786107351; cv=none; b=V+hqEPupuCr3AqayJfqxAcdBnGd3wWnwouaP0LOw9+/MQyl+fZ9F+2T7ycr6rrloCeuZaUh1R9FxtH1wbtkMwtsTRyoq1cn2fEEd2ARwyluFq+zZRDOHF5Z+4AeuF9MAj8kkO2btz/mo3lIeRx+0b6PK/fow44lW7X9iDbNPdRA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786107351; c=relaxed/simple; bh=MRhHeWai50vliIMP+zO664FxjWTOGc7oGOI8/wkJ/bo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=n3zGyAEhieL5QDl7b5PUn+6x382HMesBE3lxGRK5iForEyxoThaZH4AiTHDy/rF4smHXyRU0/LLm8o3K3BzlFVwXtyXmvDTJmcyx31P3ZAMC3RNV9LN85+yOc6/PRVm9wCks8j3H/jOmsNNhcbNDW7qO+g267Gkoco4+ypnHvKc= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GpyHPV32 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 681B44BB58B2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786107351; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OPxL/9eUxY+4muTDHTfifo5k6sEh6mBpbA5E4D7o1Q4=; b=GpyHPV32xFTd4a0VAyTQX4xfyT9+GGVIXA5oo+ksyMKD8tKW08LbT3K/WZGOekD7dJp/3f /90/W1m1ZgwfKvTgZ9X6kHbBfQNmbDTR72oDp/aUsxql9rPYWpDWm8D7HPB0D0hxcn5J0q dyeJG6LB1AR1hdeMpUqJ5tPrCrx5ts8= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-241-UESHmqhhNeKA8h-4jGCE1g-1; Fri, 07 Aug 2026 08:55:50 -0400 X-MC-Unique: UESHmqhhNeKA8h-4jGCE1g-1 X-Mimecast-MFC-AGG-ID: UESHmqhhNeKA8h-4jGCE1g_1786107349 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c07f25de2so27115611cf.3 for ; Fri, 07 Aug 2026 05:55:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786107349; x=1786712149; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OPxL/9eUxY+4muTDHTfifo5k6sEh6mBpbA5E4D7o1Q4=; b=dBiv52Bu/NUP2IASxvXheR7+uVVBqM/SJ4xJqZz7urDmEntyso5dMEy8i6SSXhzu2+ T6oyV+aeC6tlDsqk/gntJY/6QR/zBSordNl8nKlsDmLFyFqZbrl3b9/QvdPeZE2vPb01 vm6mIwuB45vzfVKi/AB4/SeOydXFAx+HknDSWU98HhI47vUd+TTtYyQagAYucU3tqe1i ag8KMk/V23ZviqTwescPrYX2fljjJiQIgfl24/BZqN3chyN0bwkLN6OJlsz7A4cSqwD2 8hbHy4QBIOZMqoqCgATRsmMALq2XFFPiBedt+ucIAc5tZDwkJZ3HCqYplyNfSjnsdiM1 rxnQ== X-Forwarded-Encrypted: i=1; AHgh+Rr57n05U8iZbWgYG+3bFBbLXzgSqkeSQBP2GkHKD5Ctos+5o/jkMBfIX5urZFMY595XEE5J8i2viyO1zg==@sourceware.org X-Gm-Message-State: AOJu0YyX9x7U6f1sBumwGa2spzScd8qo31GzkyNEN7FonOeuaANvjV6c Mwg2ho8GLEGOik3kQLFSQNzB45VBYJhPi5WtkHbnaUtDSXAy5eK23Qts3+bv2koOrCQCzDALB+F RlBeIsqix6nnTdV+Vlbx/pgmaXRPDMVKJWsgiLL3pj66dcE1f19LptLNw0FahSqY= X-Gm-Gg: AR+sD12YtDwX3OqgN0Hx+Y/7QbEcR+zBTU/SbtPUeZWZOvjEaXlVExb9GVW4RXKdKo+ dsmaYAGerZjcLxxrjHWSNpfu1Z7MAwfMyI47asQPB25xH51FhIOwXR10vkhmjtfaKmHYa15jdnn TeaQ32+A+CLjXS/pSNQoQpy0lYtCfUT9Xl8WlIT9W+URdjD0EBIl3PfLVgJU8u3CN4C5VQY2oG9 yNQ9pwf9rceUZYlhv5MXtmLkdh4cFcziL19J5nItVHrPDFqr4Y3oLXyyptLZ2ovVEgVzWZazLwf bMyUy3JdTAVGg3jmZgExxOMtxl0dVNy/BczyY4FL6UX0rlu4O3ewckKWC/ZMBwL+7FgKOGqUuoD ATj0H2T7HpA== X-Received: by 2002:a05:622a:2b49:b0:527:6d4a:1970 with SMTP id d75a77b69052e-52d20a7bc1amr3809381cf.38.1786107349510; Fri, 07 Aug 2026 05:55:49 -0700 (PDT) X-Received: by 2002:a05:622a:2b49:b0:527:6d4a:1970 with SMTP id d75a77b69052e-52d20a7bc1amr3808801cf.38.1786107349089; Fri, 07 Aug 2026 05:55:49 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:993e::75d? ([2804:14d:8084:993e::75d]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-908a9352288sm8028366d6.48.2026.08.07.05.55.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2026 05:55:48 -0700 (PDT) Message-ID: <29f1ed95-f14d-443d-bce7-c126c4790d1d@redhat.com> Date: Fri, 7 Aug 2026 09:55:45 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] Remove some bfd_boolean uses To: Tom Tromey , gdb-patches@sourceware.org References: <20260307-no-bfd-boolean-v1-0-186424bf8238@tromey.com> From: Guinevere Larsen In-Reply-To: <20260307-no-bfd-boolean-v1-0-186424bf8238@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -bPEgGKB8j3wGvearTEMp9T0-NRNY4-KmoTcRJmxQ44_1786107349 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/7/26 3:20 PM, Tom Tromey wrote: > I saw some recent commits removing uses of bfd_boolean from the tree. > This series removes the remaining uses from gdb as well, and then > arranges to poison the identifier using the BFD-supplied approach. > > Signed-off-by: Tom Tromey > --- Hi Tom! I looked over this series and everything looks ok to me. I have sent a nitpick suggestion on patch 3, but otherwise I think this looks nice Reviewed-By: Guinevere Larsen > Tom Tromey (4): > Use bool, not bfd_boolean > Don't use BFD TRUE/FALSE constants > Drop use of bfd_boolean from findcmd.c > Poison bfd_boolean > > gdb/arc-linux-tdep.c | 6 +++--- > gdb/compile/compile-object-load.c | 4 ++-- > gdb/defs.h | 2 ++ > gdb/elfread.c | 2 +- > gdb/findcmd.c | 33 +++++++++++++-------------------- > gdb/ft32-tdep.c | 6 +++--- > gdb/machoread.c | 4 ++-- > 7 files changed, 26 insertions(+), 31 deletions(-) > --- > base-commit: a00fddb175ff5cb9edef18beedfba38fc6fc6017 > change-id: 20260307-no-bfd-boolean-1c8cbdbf2849 > > Best regards, -- Cheers, Guinevere Larsen it/its she/her (deprecated)