From: Simon Marchi <simark@simark.ca>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb] Print user/includes fields for maint commands
Date: Tue, 24 Mar 2020 19:15:58 -0400 [thread overview]
Message-ID: <29c52e83-a22f-f685-432a-42a9ddf91c46@simark.ca> (raw)
In-Reply-To: <8054dea8-5a3a-7391-715e-2ba17603ef62@simark.ca>
On 2020-03-24 7:14 p.m., Simon Marchi wrote:
> On 2020-03-24 6:55 p.m., Tom de Vries wrote:
>> The first if-else covers printing the block info.
>>
>> If we'd merge the if-else and the following if, we'd have:
>> - the true clause related to block info
>> - the code related to user/includes
>> - the false clause related to block info
>> which I find confusing.
>
> Ok makes sense. Perhaps then add a comment to introduce that if, to say what's
> it's meant to do.
>
> /* Print info about the user of this compunit_symtab, and the compunit_symtabs included by this one. */
>
> Simon
>
I forgot to mention, the patch is ok with that added.
Thanks,
Simon
prev parent reply other threads:[~2020-03-24 23:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 11:22 Tom de Vries
2020-03-24 17:04 ` Simon Marchi
2020-03-24 22:28 ` Tom de Vries
2020-03-24 22:41 ` Simon Marchi
2020-03-24 22:55 ` Tom de Vries
2020-03-24 23:14 ` Simon Marchi
2020-03-24 23:15 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29c52e83-a22f-f685-432a-42a9ddf91c46@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox