From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 2595A385B834 for ; Tue, 24 Mar 2020 23:15:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2595A385B834 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id BE0471E5F8; Tue, 24 Mar 2020 19:15:58 -0400 (EDT) Subject: Re: [PATCH][gdb] Print user/includes fields for maint commands From: Simon Marchi To: Tom de Vries , gdb-patches@sourceware.org References: <20200324112241.GA23197@delia> <0e3c47b7-9cec-5efa-c3cf-8bff63042886@simark.ca> <2b576b9e-82c4-a76b-ce54-b6828d1f49af@suse.de> <9dcaf2a7-e591-5a5a-9464-b3913f435700@simark.ca> <8831bf74-3132-4a67-30f0-86887bf37865@suse.de> <8054dea8-5a3a-7391-715e-2ba17603ef62@simark.ca> Message-ID: <29c52e83-a22f-f685-432a-42a9ddf91c46@simark.ca> Date: Tue, 24 Mar 2020 19:15:58 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <8054dea8-5a3a-7391-715e-2ba17603ef62@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US-large Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-15.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Mar 2020 23:16:00 -0000 On 2020-03-24 7:14 p.m., Simon Marchi wrote: > On 2020-03-24 6:55 p.m., Tom de Vries wrote: >> The first if-else covers printing the block info. >> >> If we'd merge the if-else and the following if, we'd have: >> - the true clause related to block info >> - the code related to user/includes >> - the false clause related to block info >> which I find confusing. > > Ok makes sense. Perhaps then add a comment to introduce that if, to say what's > it's meant to do. > > /* Print info about the user of this compunit_symtab, and the compunit_symtabs included by this one. */ > > Simon > I forgot to mention, the patch is ok with that added. Thanks, Simon