[pushed] Re: [RFA/v5] (Ada) New command to stop at start of exception handler.

[Xavier Roirand <roirand@adacore.com>]

Thanks. Pushed to master.

https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=9f757bf7fcb8834ead780e0c4a76d6029b1402c2

Le 1/3/18 à 4:23 AM, Joel Brobecker a écrit :
> Hi Xavier,
> 
>> gdb/ChangeLog:
>>
>>          * ada-lang.h (ada_exception_catchpoint_kind) <ada_catch_handlers>:
>>          Add field.
>>          * ada-lang.c (struct exception_support_info) <catch_handlers_sym>:
>>          Add field.
>>          (default_exception_support_info) <catch_handlers_sym>: Add field.
>>          (exception_support_info_fallback) <catch_handlers_sym>: Add field.
>>          (ada_exception_name_addr_1): Add "catch handlers" handling.
>>          (ada_exception_catchpoint_cond_string) <ex>: New parameter.
>>          Update all callers.
>>          (create_excep_cond_exprs) <ex>: Add parameter.
>>          (re_set_exception): Update create_excep_cond_exprs call.
>>          (print_it_exception, print_one_exception, print_mention_exception)
>>          (print_recreate_exception): Add "catch handler" handling.
>>          (allocate_location_catch_handlers, re_set_catch_handlers)
>>          (check_status_catch_handlers, print_it_catch_handlers)
>>          (print_one_catch_handlers, print_mention_catch_handlers)
>>          (print_recreate_catch_handlers): New function.
>>          (catch_handlers_breakpoint_ops): New variable.
>>          (catch_ada_exception_command_split) <is_catch_handlers_cmd>:
>>          Add parameter.  Add "catch handler" handling.
>>          (ada_exception_sym_name, ada_exception_breakpoint_ops):
>>          Add "catch handler" handling.
>>          (ada_exception_catchpoint_cond_string): Add "catch handler"
>>          handling.
>>          (create_ada_exception_catchpoint): Update create_excep_cond_exprs
>>          call.
>>          (catch_ada_handlers_command): New function.
>>          (initialize_ada_catchpoint_ops): Initialize "catch handlers"
>>          operations structure.
>>          (_initialize_ada_language): Add "catch handlers" command entry.
>>          * NEWS: Document "catch handlers" feature.
>>
>> gdb/doc/ChangeLog:
>>
>>          * gdb.texinfo (Set Catchpoints): Add documentation for new
>>          "catch handlers" action.
>>
>> gdb/testsuite/ChangeLog:
>>
>>          gdb.ada/excep_handle.exp: New testcase.
>>          gdb.ada/excep_handle/foo.adb: New file.
>>          gdb.ada/excep_handle/pck.ads: New file.
>>
>> Tested on x86_64-linux.
> 
> Looks good. You can go ahead and push. Just remember to
> actually add the 3 ChangeLog entries before doing so! ;-)
>