From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91598 invoked by alias); 3 Jan 2018 14:00:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91534 invoked by uid 89); 3 Jan 2018 14:00:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2308 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Jan 2018 14:00:01 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 641BE81385 for ; Wed, 3 Jan 2018 14:59:59 +0100 (CET) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b8rW2G6MG1tq for ; Wed, 3 Jan 2018 14:59:59 +0100 (CET) Received: from Xaviers-MacBook-Pro.local (unknown [46.18.100.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 3F51D81382 for ; Wed, 3 Jan 2018 14:59:59 +0100 (CET) Subject: [pushed] Re: [RFA/v5] (Ada) New command to stop at start of exception handler. To: gdb-patches@sourceware.org References: <1514908089-29151-1-git-send-email-roirand@adacore.com> <20180103032345.evvfmbcaubfy43uw@adacore.com> From: Xavier Roirand Message-ID: <2857c64e-8f61-5e0c-d461-529d449c60fb@adacore.com> Date: Wed, 03 Jan 2018 14:00:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180103032345.evvfmbcaubfy43uw@adacore.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00028.txt.bz2 Thanks. Pushed to master. https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=9f757bf7fcb8834ead780e0c4a76d6029b1402c2 Le 1/3/18 à 4:23 AM, Joel Brobecker a écrit : > Hi Xavier, > >> gdb/ChangeLog: >> >> * ada-lang.h (ada_exception_catchpoint_kind) : >> Add field. >> * ada-lang.c (struct exception_support_info) : >> Add field. >> (default_exception_support_info) : Add field. >> (exception_support_info_fallback) : Add field. >> (ada_exception_name_addr_1): Add "catch handlers" handling. >> (ada_exception_catchpoint_cond_string) : New parameter. >> Update all callers. >> (create_excep_cond_exprs) : Add parameter. >> (re_set_exception): Update create_excep_cond_exprs call. >> (print_it_exception, print_one_exception, print_mention_exception) >> (print_recreate_exception): Add "catch handler" handling. >> (allocate_location_catch_handlers, re_set_catch_handlers) >> (check_status_catch_handlers, print_it_catch_handlers) >> (print_one_catch_handlers, print_mention_catch_handlers) >> (print_recreate_catch_handlers): New function. >> (catch_handlers_breakpoint_ops): New variable. >> (catch_ada_exception_command_split) : >> Add parameter. Add "catch handler" handling. >> (ada_exception_sym_name, ada_exception_breakpoint_ops): >> Add "catch handler" handling. >> (ada_exception_catchpoint_cond_string): Add "catch handler" >> handling. >> (create_ada_exception_catchpoint): Update create_excep_cond_exprs >> call. >> (catch_ada_handlers_command): New function. >> (initialize_ada_catchpoint_ops): Initialize "catch handlers" >> operations structure. >> (_initialize_ada_language): Add "catch handlers" command entry. >> * NEWS: Document "catch handlers" feature. >> >> gdb/doc/ChangeLog: >> >> * gdb.texinfo (Set Catchpoints): Add documentation for new >> "catch handlers" action. >> >> gdb/testsuite/ChangeLog: >> >> gdb.ada/excep_handle.exp: New testcase. >> gdb.ada/excep_handle/foo.adb: New file. >> gdb.ada/excep_handle/pck.ads: New file. >> >> Tested on x86_64-linux. > > Looks good. You can go ahead and push. Just remember to > actually add the 3 ChangeLog entries before doing so! ;-) >