Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2][PR cli/22573] Honour 'print pretty' when printing result of finish command
Date: Thu, 14 Jun 2018 13:45:00 -0000	[thread overview]
Message-ID: <277f026e-2138-50f4-862f-9a15ca7db758@suse.de> (raw)
In-Reply-To: <5cd6f7f2-3425-4c77-b2eb-a9530256519e@redhat.com>

On 06/14/2018 12:55 PM, Pedro Alves wrote:
> OK with the typo below fixed.  Please make sure the git commit log
> includes the rationale [1], and push.
> 

> [1] - sorry to be a nag, but your previous push did not include it.  :-)

No problem, much appreciated.

Currently I add the rationale manually pre-commit, so it's something
that I might forget. I need to update my pre-commit script to handle
this log format, and then I'll try to train myself to add the rationale
in the log before submission.

Thanks,
- Tom


      reply	other threads:[~2018-06-14 13:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-09 17:07 [PATCH][PR " Tom de Vries
2018-06-13 15:50 ` Pedro Alves
2018-06-14  9:48   ` [PATCH v2][PR " Tom de Vries
2018-06-14 10:55     ` Pedro Alves
2018-06-14 13:45       ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=277f026e-2138-50f4-862f-9a15ca7db758@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox