From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31948 invoked by alias); 14 Jun 2018 13:45:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31879 invoked by uid 89); 14 Jun 2018 13:45:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Jun 2018 13:44:59 +0000 Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 4B86BAD53; Thu, 14 Jun 2018 13:44:57 +0000 (UTC) Subject: Re: [PATCH v2][PR cli/22573] Honour 'print pretty' when printing result of finish command To: Pedro Alves Cc: gdb-patches@sourceware.org References: <20180609170752.2s4kdlyhat5d5bnn@localhost.localdomain> <4504da7f-593e-c8af-8ac9-40930cf9ce11@redhat.com> <20180614094758.ipkygcmpxdjpmfsj@localhost.localdomain> <5cd6f7f2-3425-4c77-b2eb-a9530256519e@redhat.com> From: Tom de Vries Message-ID: <277f026e-2138-50f4-862f-9a15ca7db758@suse.de> Date: Thu, 14 Jun 2018 13:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <5cd6f7f2-3425-4c77-b2eb-a9530256519e@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00359.txt.bz2 On 06/14/2018 12:55 PM, Pedro Alves wrote: > OK with the typo below fixed. Please make sure the git commit log > includes the rationale [1], and push. > > [1] - sorry to be a nag, but your previous push did not include it. :-) No problem, much appreciated. Currently I add the rationale manually pre-commit, so it's something that I might forget. I need to update my pre-commit script to handle this log format, and then I'll try to train myself to add the rationale in the log before submission. Thanks, - Tom