* so-thresh.exp problems
@ 2001-12-20 14:28 law
2001-12-20 14:33 ` Fernando Nasser
0 siblings, 1 reply; 6+ messages in thread
From: law @ 2001-12-20 14:28 UTC (permalink / raw)
To: gdb-patches
We're failing a handful of the so-thresh.exp tests on the PA. There's a
few issues that need to be addressed.
* The coommand to set the autoload threshold is
auto-solib-limit, not auto-solib-add. That was a global
search and replace in so-thresh.exp.
* Some of the text related to auto-solib-limit has been changed
over time and so-thresh.exp wasn't updated. Oops.
* A threshold of zero indicates that no threshold is in place.
somsolib.c needed to be tweaked to handle that properly.
* The test assumes you're compiling with HP's compiler. So
the makefile has been updated to force the use of cc.
With these patches we now pass so-thresh.exp without any unexpected failures.
* somsolib.c (som_solib_add): Ignore the solib limit threshhold
if AUTO_SOLIB_LIMIT is not greater than zero.
* gdb.hp/gdb.base-hp/so-thresh.exp: Update text in expect strings
to match current gdb output. Update due to using auto-solib-limit
for limiting instead of overloading auto-solib-add.
* gdb.hp/gdb.base-hp/so-thresh.mk: Always use "cc" to build the
test program.
Index: somsolib.c
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/somsolib.c,v
retrieving revision 2.48.12.1
diff -c -3 -p -r2.48.12.1 somsolib.c
*** somsolib.c 2001/12/19 21:21:38 2.48.12.1
--- somsolib.c 2001/12/20 22:18:36
*************** som_solib_add (char *arg_string, int fro
*** 777,782 ****
--- 777,783 ----
st_size = som_solib_sizeof_symbol_table (name);
som_solib_st_size_threshold_exceeded =
!from_tty &&
+ auto_solib_limit > 0 &&
readsyms &&
((st_size + som_solib_total_st_size) > (auto_solib_limit * (LONGEST) (1024
* 1024)));
Index: testsuite/gdb.hp/gdb.base-hp/so-thresh.exp
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/testsuite/gdb.hp/gdb.base-hp/so-thresh.exp,v
retrieving revision 1.1
diff -c -3 -p -r1.1 so-thresh.exp
*** so-thresh.exp 1999/08/10 01:54:31 1.1
--- so-thresh.exp 2001/12/20 22:18:36
*************** send_user "Making with '${srcdir}/${subd
*** 67,73 ****
remote_exec build "${srcdir}/${subdir}/${testfile}.sh $subdir"
# Only HP-UX (and any other platforms using SOM shared libraries, I
! # guess) interprets the auto-solib-add variable as a threshhold,
# rather than a boolean that strictly enables or disables automatic
# loading of shlib symbol tables.
#
--- 67,73 ----
remote_exec build "${srcdir}/${subdir}/${testfile}.sh $subdir"
# Only HP-UX (and any other platforms using SOM shared libraries, I
! # guess) interprets the auto-solib-limit variable as a threshhold,
# rather than a boolean that strictly enables or disables automatic
# loading of shlib symbol tables.
#
*************** gdb_load ${binfile}
*** 90,133 ****
# debugger's symbol table reaches a specified threshhold.
#
! # On HP-UX, the help text for auto-solib-add mentions that it
# serves as a threshhold.
#
! send_gdb "help set auto-solib-add\n"
gdb_expect {
! -re "Set autoloading size threshold .in megabytes. of shared library
symbols.*
! If nonzero, symbols from all shared object libraries will be loaded.*
! automatically when the inferior begins execution or when the dynamic linker.*
! informs gdb that a new library has been loaded, until the symbol table.*
! of the program and libraries exceeds this threshold.*
! Otherwise, symbols must be loaded manually, using
`sharedlibrary'.*$gdb_prompt $"\
! {pass "help set auto-solib-add"}
-re "$gdb_prompt $"\
! {fail "help set auto-solib-add"}
! timeout {fail "(timeout) help set auto-solib-add"}
}
# On HP-UX, the threshhold is by default set to 50, which means
# 50 megabytes.
#
! send_gdb "show auto-solib-add\n"
gdb_expect {
! -re "Autoloading size threshold .in megabytes. of shared library symbols
is $decimal.*$gdb_prompt $"\
! {pass "show auto-solib-add "}
! -re "Autoloading size threshold \(in megabytes\) of shared library symbols
is $decimal.$gdb_prompt $"\
! {pass "show auto-solib-add "}
-re "$gdb_prompt $"\
! {fail "show auto-solib-add "}
! timeout {fail "(timeout) show auto-solib-add "}
}
! send_gdb "set auto-solib-add 1\n"
gdb_expect {
-re ".*$gdb_prompt $"
! {pass "set auto-solib-add to 1"}
-re ".*$gdb_prompt $"
! {fail "set auto-solib-add to 1"}
! timeout {fail "(timeout) set auto-solib-add to 1"}
}
--- 90,129 ----
# debugger's symbol table reaches a specified threshhold.
#
! # On HP-UX, the help text for auto-solib-limit mentions that it
# serves as a threshhold.
#
! send_gdb "help set auto-solib-limit\n"
gdb_expect {
! -re "Set threshold .in Mb. for autoloading shared library symbols.*
! When shared library autoloading is enabled, new libraries will be loaded.*
! only until the total size of shared library symbols exceeds this.*
! threshold in megabytes. Is ignored when using .sharedlibrary.*$gdb_prompt
$"\
! {pass "help set auto-solib-limit"}
-re "$gdb_prompt $"\
! {fail "help set auto-solib-limit"}
! timeout {fail "(timeout) help set auto-solib-limit"}
}
# On HP-UX, the threshhold is by default set to 50, which means
# 50 megabytes.
#
! send_gdb "show auto-solib-limit\n"
gdb_expect {
! -re "Threshold .in Mb. for autoloading shared library symbols is
$decimal.*$gdb_prompt $"\
! {pass "show auto-solib-limit "}
-re "$gdb_prompt $"\
! {fail "show auto-solib-limit "}
! timeout {fail "(timeout) show auto-solib-limit "}
}
! send_gdb "set auto-solib-limit 1\n"
gdb_expect {
-re ".*$gdb_prompt $"
! {pass "set auto-solib-limit to 1"}
-re ".*$gdb_prompt $"
! {fail "set auto-solib-limit to 1"}
! timeout {fail "(timeout) set auto-solib-limit to 1"}
}
*************** gdb_expect {
*** 152,165 ****
send_gdb "run\n"
gdb_expect {
-re ".*warning. Symbols for some libraries have not been loaded, because.*
! doing so would exceed the size threshold specified by auto-solib-add.*
To manually load symbols, use the 'sharedlibrary' command.*
! To raise the threshold, set auto-solib-add to a larger value and rerun.*
the program.*$gdb_prompt $"\
! {pass "run to main hit auto-solib-add threshold"}
-re "$gdb_prompt $"\
! {fail "run to main hit auto-solib-add threshold"}
! timeout {fail "(timeout) run to main hit auto-solib-add threshold"}
}
# Verify that "info share" mentions something about libraries whose
--- 148,161 ----
send_gdb "run\n"
gdb_expect {
-re ".*warning. Symbols for some libraries have not been loaded, because.*
! doing so would exceed the size threshold specified by auto-solib-limit.*
To manually load symbols, use the 'sharedlibrary' command.*
! To raise the threshold, set auto-solib-limit to a larger value and rerun.*
the program.*$gdb_prompt $"\
! {pass "run to main hit auto-solib-limit threshold"}
-re "$gdb_prompt $"\
! {fail "run to main hit auto-solib-limit threshold"}
! timeout {fail "(timeout) run to main hit auto-solib-limit threshold"}
}
# Verify that "info share" mentions something about libraries whose
*************** gdb_expect {
*** 251,268 ****
timeout {fail "(timeout) 2 set break at main"}
}
! send_gdb "set auto-solib-add 9999\n"
gdb_expect {
-re "$gdb_prompt $"\
! {pass "set auto-solib-add threshold to practical infinity"}
! timeout {fail "(timeout) set auto-solib-add threshold to practical
infinity"}
}
send_gdb "run\n"
gdb_expect {
-re ".*warning. Symbols for some libraries have not been loaded, because.*
! doing so would exceed the size threshold specified by auto-solib-add.*
To manually load symbols, use the 'sharedlibrary' command.*
! To raise the threshold, set auto-solib-add to a larger value and rerun.*
the program.*$gdb_prompt $"\
{fail "rerun threshold at practical infinity (still hit
threshold)"}
-re "$gdb_prompt $"\
--- 247,264 ----
timeout {fail "(timeout) 2 set break at main"}
}
! send_gdb "set auto-solib-limit 9999\n"
gdb_expect {
-re "$gdb_prompt $"\
! {pass "set auto-solib-limit threshold to practical infinity"}
! timeout {fail "(timeout) set auto-solib-limit threshold to practical
infinity"}
}
send_gdb "run\n"
gdb_expect {
-re ".*warning. Symbols for some libraries have not been loaded, because.*
! doing so would exceed the size threshold specified by auto-solib-limit.*
To manually load symbols, use the 'sharedlibrary' command.*
! To raise the threshold, set auto-solib-limit to a larger value and rerun.*
the program.*$gdb_prompt $"\
{fail "rerun threshold at practical infinity (still hit
threshold)"}
-re "$gdb_prompt $"\
*************** gdb_expect {
*** 297,314 ****
timeout {fail "(timeout) 3 set break at main"}
}
! send_gdb "set auto-solib-add 0\n"
gdb_expect {
-re "$gdb_prompt $"\
! {pass "set auto-solib-add threshold to 0"}
! timeout {fail "(timeout) set auto-solib-add threshold to 0"}
}
send_gdb "run\n"
gdb_expect {
-re ".*warning. Symbols for some libraries have not been loaded, because.*
! doing so would exceed the size threshold specified by auto-solib-add.*
To manually load symbols, use the 'sharedlibrary' command.*
! To raise the threshold, set auto-solib-add to a larger value and rerun.*
the program.*$gdb_prompt $"\
{fail "rerun threshold at 0 (still hit threshold)"}
-re "$gdb_prompt $"\
--- 293,310 ----
timeout {fail "(timeout) 3 set break at main"}
}
! send_gdb "set auto-solib-limit 0\n"
gdb_expect {
-re "$gdb_prompt $"\
! {pass "set auto-solib-limit threshold to 0"}
! timeout {fail "(timeout) set auto-solib-limit threshold to 0"}
}
send_gdb "run\n"
gdb_expect {
-re ".*warning. Symbols for some libraries have not been loaded, because.*
! doing so would exceed the size threshold specified by auto-solib-limit.*
To manually load symbols, use the 'sharedlibrary' command.*
! To raise the threshold, set auto-solib-limit to a larger value and rerun.*
the program.*$gdb_prompt $"\
{fail "rerun threshold at 0 (still hit threshold)"}
-re "$gdb_prompt $"\
Index: testsuite/gdb.hp/gdb.base-hp/so-thresh.mk
===================================================================
RCS file: /cvs/cvsfiles/devo/gdb/testsuite/gdb.hp/gdb.base-hp/so-thresh.mk,v
retrieving revision 1.1
diff -c -3 -p -r1.1 so-thresh.mk
*** so-thresh.mk 1999/08/10 01:54:31 1.1
--- so-thresh.mk 2001/12/20 22:18:36
***************
*** 3,8 ****
--- 3,9 ----
OBJDIR=.
SRCDIR=.
CFLAGS = +DA1.1 -g
+ CC=cc
# This is how to build this generator.
genso-thresh.o: ${SRCDIR}/genso-thresh.c
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: so-thresh.exp problems
2001-12-20 14:28 so-thresh.exp problems law
@ 2001-12-20 14:33 ` Fernando Nasser
2001-12-20 15:08 ` Kevin Buettner
2001-12-20 15:33 ` law
0 siblings, 2 replies; 6+ messages in thread
From: Fernando Nasser @ 2001-12-20 14:33 UTC (permalink / raw)
To: law; +Cc: gdb-patches
Nobody currently maintains the gdb.hp part of the testsuite, so you
can check fixes in if you want. I am sure it will improve things.
But I don't know about gdb/somsolib.c. As a "Past Maintainer", you are
probably the closest thing we have for an HP maintainer :-) But is not
my call.
Regards,
Fernando
law@redhat.com wrote:
>
> We're failing a handful of the so-thresh.exp tests on the PA. There's a
> few issues that need to be addressed.
>
> * The coommand to set the autoload threshold is
> auto-solib-limit, not auto-solib-add. That was a global
> search and replace in so-thresh.exp.
>
> * Some of the text related to auto-solib-limit has been changed
> over time and so-thresh.exp wasn't updated. Oops.
>
> * A threshold of zero indicates that no threshold is in place.
> somsolib.c needed to be tweaked to handle that properly.
>
> * The test assumes you're compiling with HP's compiler. So
> the makefile has been updated to force the use of cc.
>
> With these patches we now pass so-thresh.exp without any unexpected failures.
>
>
> * somsolib.c (som_solib_add): Ignore the solib limit threshhold
> if AUTO_SOLIB_LIMIT is not greater than zero.
>
> * gdb.hp/gdb.base-hp/so-thresh.exp: Update text in expect strings
> to match current gdb output. Update due to using auto-solib-limit
> for limiting instead of overloading auto-solib-add.
> * gdb.hp/gdb.base-hp/so-thresh.mk: Always use "cc" to build the
> test program.
>
> Index: somsolib.c
> ===================================================================
> RCS file: /cvs/cvsfiles/devo/gdb/somsolib.c,v
> retrieving revision 2.48.12.1
> diff -c -3 -p -r2.48.12.1 somsolib.c
> *** somsolib.c 2001/12/19 21:21:38 2.48.12.1
> --- somsolib.c 2001/12/20 22:18:36
> *************** som_solib_add (char *arg_string, int fro
> *** 777,782 ****
> --- 777,783 ----
> st_size = som_solib_sizeof_symbol_table (name);
> som_solib_st_size_threshold_exceeded =
> !from_tty &&
> + auto_solib_limit > 0 &&
> readsyms &&
> ((st_size + som_solib_total_st_size) > (auto_solib_limit * (LONGEST) (1024
> * 1024)));
>
> Index: testsuite/gdb.hp/gdb.base-hp/so-thresh.exp
> ===================================================================
> RCS file: /cvs/cvsfiles/devo/gdb/testsuite/gdb.hp/gdb.base-hp/so-thresh.exp,v
> retrieving revision 1.1
> diff -c -3 -p -r1.1 so-thresh.exp
> *** so-thresh.exp 1999/08/10 01:54:31 1.1
> --- so-thresh.exp 2001/12/20 22:18:36
> *************** send_user "Making with '${srcdir}/${subd
> *** 67,73 ****
> remote_exec build "${srcdir}/${subdir}/${testfile}.sh $subdir"
>
> # Only HP-UX (and any other platforms using SOM shared libraries, I
> ! # guess) interprets the auto-solib-add variable as a threshhold,
> # rather than a boolean that strictly enables or disables automatic
> # loading of shlib symbol tables.
> #
> --- 67,73 ----
> remote_exec build "${srcdir}/${subdir}/${testfile}.sh $subdir"
>
> # Only HP-UX (and any other platforms using SOM shared libraries, I
> ! # guess) interprets the auto-solib-limit variable as a threshhold,
> # rather than a boolean that strictly enables or disables automatic
> # loading of shlib symbol tables.
> #
> *************** gdb_load ${binfile}
> *** 90,133 ****
> # debugger's symbol table reaches a specified threshhold.
> #
>
> ! # On HP-UX, the help text for auto-solib-add mentions that it
> # serves as a threshhold.
> #
> ! send_gdb "help set auto-solib-add\n"
> gdb_expect {
> ! -re "Set autoloading size threshold .in megabytes. of shared library
> symbols.*
> ! If nonzero, symbols from all shared object libraries will be loaded.*
> ! automatically when the inferior begins execution or when the dynamic linker.*
> ! informs gdb that a new library has been loaded, until the symbol table.*
> ! of the program and libraries exceeds this threshold.*
> ! Otherwise, symbols must be loaded manually, using
> `sharedlibrary'.*$gdb_prompt $"\
> ! {pass "help set auto-solib-add"}
> -re "$gdb_prompt $"\
> ! {fail "help set auto-solib-add"}
> ! timeout {fail "(timeout) help set auto-solib-add"}
> }
>
> # On HP-UX, the threshhold is by default set to 50, which means
> # 50 megabytes.
> #
> ! send_gdb "show auto-solib-add\n"
> gdb_expect {
> ! -re "Autoloading size threshold .in megabytes. of shared library symbols
> is $decimal.*$gdb_prompt $"\
> ! {pass "show auto-solib-add "}
> ! -re "Autoloading size threshold \(in megabytes\) of shared library symbols
> is $decimal.$gdb_prompt $"\
> ! {pass "show auto-solib-add "}
> -re "$gdb_prompt $"\
> ! {fail "show auto-solib-add "}
> ! timeout {fail "(timeout) show auto-solib-add "}
> }
>
> ! send_gdb "set auto-solib-add 1\n"
> gdb_expect {
> -re ".*$gdb_prompt $"
> ! {pass "set auto-solib-add to 1"}
> -re ".*$gdb_prompt $"
> ! {fail "set auto-solib-add to 1"}
> ! timeout {fail "(timeout) set auto-solib-add to 1"}
> }
>
>
> --- 90,129 ----
> # debugger's symbol table reaches a specified threshhold.
> #
>
> ! # On HP-UX, the help text for auto-solib-limit mentions that it
> # serves as a threshhold.
> #
> ! send_gdb "help set auto-solib-limit\n"
> gdb_expect {
> ! -re "Set threshold .in Mb. for autoloading shared library symbols.*
> ! When shared library autoloading is enabled, new libraries will be loaded.*
> ! only until the total size of shared library symbols exceeds this.*
> ! threshold in megabytes. Is ignored when using .sharedlibrary.*$gdb_prompt
> $"\
> ! {pass "help set auto-solib-limit"}
> -re "$gdb_prompt $"\
> ! {fail "help set auto-solib-limit"}
> ! timeout {fail "(timeout) help set auto-solib-limit"}
> }
>
> # On HP-UX, the threshhold is by default set to 50, which means
> # 50 megabytes.
> #
> ! send_gdb "show auto-solib-limit\n"
> gdb_expect {
> ! -re "Threshold .in Mb. for autoloading shared library symbols is
> $decimal.*$gdb_prompt $"\
> ! {pass "show auto-solib-limit "}
> -re "$gdb_prompt $"\
> ! {fail "show auto-solib-limit "}
> ! timeout {fail "(timeout) show auto-solib-limit "}
> }
>
> ! send_gdb "set auto-solib-limit 1\n"
> gdb_expect {
> -re ".*$gdb_prompt $"
> ! {pass "set auto-solib-limit to 1"}
> -re ".*$gdb_prompt $"
> ! {fail "set auto-solib-limit to 1"}
> ! timeout {fail "(timeout) set auto-solib-limit to 1"}
> }
>
>
> *************** gdb_expect {
> *** 152,165 ****
> send_gdb "run\n"
> gdb_expect {
> -re ".*warning. Symbols for some libraries have not been loaded, because.*
> ! doing so would exceed the size threshold specified by auto-solib-add.*
> To manually load symbols, use the 'sharedlibrary' command.*
> ! To raise the threshold, set auto-solib-add to a larger value and rerun.*
> the program.*$gdb_prompt $"\
> ! {pass "run to main hit auto-solib-add threshold"}
> -re "$gdb_prompt $"\
> ! {fail "run to main hit auto-solib-add threshold"}
> ! timeout {fail "(timeout) run to main hit auto-solib-add threshold"}
> }
>
> # Verify that "info share" mentions something about libraries whose
> --- 148,161 ----
> send_gdb "run\n"
> gdb_expect {
> -re ".*warning. Symbols for some libraries have not been loaded, because.*
> ! doing so would exceed the size threshold specified by auto-solib-limit.*
> To manually load symbols, use the 'sharedlibrary' command.*
> ! To raise the threshold, set auto-solib-limit to a larger value and rerun.*
> the program.*$gdb_prompt $"\
> ! {pass "run to main hit auto-solib-limit threshold"}
> -re "$gdb_prompt $"\
> ! {fail "run to main hit auto-solib-limit threshold"}
> ! timeout {fail "(timeout) run to main hit auto-solib-limit threshold"}
> }
>
> # Verify that "info share" mentions something about libraries whose
> *************** gdb_expect {
> *** 251,268 ****
> timeout {fail "(timeout) 2 set break at main"}
> }
>
> ! send_gdb "set auto-solib-add 9999\n"
> gdb_expect {
> -re "$gdb_prompt $"\
> ! {pass "set auto-solib-add threshold to practical infinity"}
> ! timeout {fail "(timeout) set auto-solib-add threshold to practical
> infinity"}
> }
> send_gdb "run\n"
> gdb_expect {
> -re ".*warning. Symbols for some libraries have not been loaded, because.*
> ! doing so would exceed the size threshold specified by auto-solib-add.*
> To manually load symbols, use the 'sharedlibrary' command.*
> ! To raise the threshold, set auto-solib-add to a larger value and rerun.*
> the program.*$gdb_prompt $"\
> {fail "rerun threshold at practical infinity (still hit
> threshold)"}
> -re "$gdb_prompt $"\
> --- 247,264 ----
> timeout {fail "(timeout) 2 set break at main"}
> }
>
> ! send_gdb "set auto-solib-limit 9999\n"
> gdb_expect {
> -re "$gdb_prompt $"\
> ! {pass "set auto-solib-limit threshold to practical infinity"}
> ! timeout {fail "(timeout) set auto-solib-limit threshold to practical
> infinity"}
> }
> send_gdb "run\n"
> gdb_expect {
> -re ".*warning. Symbols for some libraries have not been loaded, because.*
> ! doing so would exceed the size threshold specified by auto-solib-limit.*
> To manually load symbols, use the 'sharedlibrary' command.*
> ! To raise the threshold, set auto-solib-limit to a larger value and rerun.*
> the program.*$gdb_prompt $"\
> {fail "rerun threshold at practical infinity (still hit
> threshold)"}
> -re "$gdb_prompt $"\
> *************** gdb_expect {
> *** 297,314 ****
> timeout {fail "(timeout) 3 set break at main"}
> }
>
> ! send_gdb "set auto-solib-add 0\n"
> gdb_expect {
> -re "$gdb_prompt $"\
> ! {pass "set auto-solib-add threshold to 0"}
> ! timeout {fail "(timeout) set auto-solib-add threshold to 0"}
> }
> send_gdb "run\n"
> gdb_expect {
> -re ".*warning. Symbols for some libraries have not been loaded, because.*
> ! doing so would exceed the size threshold specified by auto-solib-add.*
> To manually load symbols, use the 'sharedlibrary' command.*
> ! To raise the threshold, set auto-solib-add to a larger value and rerun.*
> the program.*$gdb_prompt $"\
> {fail "rerun threshold at 0 (still hit threshold)"}
> -re "$gdb_prompt $"\
> --- 293,310 ----
> timeout {fail "(timeout) 3 set break at main"}
> }
>
> ! send_gdb "set auto-solib-limit 0\n"
> gdb_expect {
> -re "$gdb_prompt $"\
> ! {pass "set auto-solib-limit threshold to 0"}
> ! timeout {fail "(timeout) set auto-solib-limit threshold to 0"}
> }
> send_gdb "run\n"
> gdb_expect {
> -re ".*warning. Symbols for some libraries have not been loaded, because.*
> ! doing so would exceed the size threshold specified by auto-solib-limit.*
> To manually load symbols, use the 'sharedlibrary' command.*
> ! To raise the threshold, set auto-solib-limit to a larger value and rerun.*
> the program.*$gdb_prompt $"\
> {fail "rerun threshold at 0 (still hit threshold)"}
> -re "$gdb_prompt $"\
> Index: testsuite/gdb.hp/gdb.base-hp/so-thresh.mk
> ===================================================================
> RCS file: /cvs/cvsfiles/devo/gdb/testsuite/gdb.hp/gdb.base-hp/so-thresh.mk,v
> retrieving revision 1.1
> diff -c -3 -p -r1.1 so-thresh.mk
> *** so-thresh.mk 1999/08/10 01:54:31 1.1
> --- so-thresh.mk 2001/12/20 22:18:36
> ***************
> *** 3,8 ****
> --- 3,9 ----
> OBJDIR=.
> SRCDIR=.
> CFLAGS = +DA1.1 -g
> + CC=cc
>
> # This is how to build this generator.
> genso-thresh.o: ${SRCDIR}/genso-thresh.c
--
Fernando Nasser
Red Hat - Toronto E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: so-thresh.exp problems
2001-12-20 14:33 ` Fernando Nasser
@ 2001-12-20 15:08 ` Kevin Buettner
2001-12-20 15:28 ` law
2001-12-20 15:33 ` law
1 sibling, 1 reply; 6+ messages in thread
From: Kevin Buettner @ 2001-12-20 15:08 UTC (permalink / raw)
To: Fernando Nasser, law; +Cc: gdb-patches
On Dec 20, 5:33pm, Fernando Nasser wrote:
> Nobody currently maintains the gdb.hp part of the testsuite, so you
> can check fixes in if you want. I am sure it will improve things.
>
> But I don't know about gdb/somsolib.c. As a "Past Maintainer", you are
> probably the closest thing we have for an HP maintainer :-) But is not
> my call.
As one of the solib maintainers, I guess that Jeff's somsolib.c changes
are up to me to approve. I feel kind of funny about this though because
I know almost nothing about this file.
Anyhow, Jeff's somsolib.c change looks okay to me. Also, as far as
I'm concerned, Jeff can check in any other changes that he wants to
make to somsolib.c. (somsolib.c is one of those files that we want
bring into the solib-*.c fold. Anything that's done to it to put it
into working order first is more than welcome.)
Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: so-thresh.exp problems
2001-12-20 15:08 ` Kevin Buettner
@ 2001-12-20 15:28 ` law
0 siblings, 0 replies; 6+ messages in thread
From: law @ 2001-12-20 15:28 UTC (permalink / raw)
To: Kevin Buettner; +Cc: Fernando Nasser, gdb-patches
> As one of the solib maintainers, I guess that Jeff's somsolib.c changes
> are up to me to approve. I feel kind of funny about this though because
> I know almost nothing about this file.
It happens ;(
As its original author, I've got a pretty good idea about what's going on
in somsolib.c -- with the obvious exception of the stuff that came in
from HP (such as the solib-limit stuff).
> Anyhow, Jeff's somsolib.c change looks okay to me. Also, as far as
> I'm concerned, Jeff can check in any other changes that he wants to
> make to somsolib.c.
Thanks. I don't forsee needing to do any major surgery; most of the problems
I'm tripping over are related to the insane ttrace code from HP -- which
I doubt anyone outside HP actually understands.
> (somsolib.c is one of those files that we want
> bring into the solib-*.c fold. Anything that's done to it to put it
> into working order first is more than welcome.)
Feel free to ask questions if you ever want to start trying to bring it
into the fold.
Conceptually the code isn't terribly different from the other implementations,
but the guts of how we go about getting/setting the information we need is
radically different. The joys of SOM.
Thanks,
jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: so-thresh.exp problems
2001-12-20 14:33 ` Fernando Nasser
2001-12-20 15:08 ` Kevin Buettner
@ 2001-12-20 15:33 ` law
2001-12-21 7:36 ` Fernando Nasser
1 sibling, 1 reply; 6+ messages in thread
From: law @ 2001-12-20 15:33 UTC (permalink / raw)
To: Fernando Nasser; +Cc: gdb-patches
> Nobody currently maintains the gdb.hp part of the testsuite,
It shows. Then again, I have my reservations about the quality of the
code when it was installed.
For example, I just had the pleasure of finding out that HP's thread tests
all rely on a magic pre-built binary becuase they couldn't get the testfile
to build on hpux11. Of course we don't even have that binary and if we
did, it'd probably be a GPL violation to distribute it. I'll be disabling
those tests shortly :(
> so you
> can check fixes in if you want. I am sure it will improve things.
It can't hurt. Particularly when it's pretty clear that nobody's built/tested
GDB on hpux11 since Jan 2001.
> But I don't know about gdb/somsolib.c. As a "Past Maintainer", you are
> probably the closest thing we have for an HP maintainer :-) But is not
> my call.
Understood.
jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: so-thresh.exp problems
2001-12-20 15:33 ` law
@ 2001-12-21 7:36 ` Fernando Nasser
0 siblings, 0 replies; 6+ messages in thread
From: Fernando Nasser @ 2001-12-21 7:36 UTC (permalink / raw)
To: law; +Cc: gdb-patches
Jeff, I will be on vacations soon, so please consider any
changes to testsuite/gdb.hp pre-approved. You can even re-add
yourself as a maintainer for that bit if you want (just make
an obvious patch to MAINTAINERS).
Cheers,
Fernando
law@redhat.com wrote:
>
> > Nobody currently maintains the gdb.hp part of the testsuite,
> It shows. Then again, I have my reservations about the quality of the
> code when it was installed.
>
> For example, I just had the pleasure of finding out that HP's thread tests
> all rely on a magic pre-built binary becuase they couldn't get the testfile
> to build on hpux11. Of course we don't even have that binary and if we
> did, it'd probably be a GPL violation to distribute it. I'll be disabling
> those tests shortly :(
>
> > so you
> > can check fixes in if you want. I am sure it will improve things.
> It can't hurt. Particularly when it's pretty clear that nobody's built/tested
> GDB on hpux11 since Jan 2001.
>
> > But I don't know about gdb/somsolib.c. As a "Past Maintainer", you are
> > probably the closest thing we have for an HP maintainer :-) But is not
> > my call.
> Understood.
> jeff
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2001-12-21 15:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-12-20 14:28 so-thresh.exp problems law
2001-12-20 14:33 ` Fernando Nasser
2001-12-20 15:08 ` Kevin Buettner
2001-12-20 15:28 ` law
2001-12-20 15:33 ` law
2001-12-21 7:36 ` Fernando Nasser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox