Re: [PATCH v4] [PR gdb/27614] gdb-add-index fails on symlinks.

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2021-03-29 4:52 p.m., Lancelot SIX via Gdb-patches wrote:
> Since V3:
> 	- Do net rely on GDB's maintenance commands to resolve
> 	symlinks, revert to using readlink while maximizing portability.
> 
> Since V2:
> 	- Use GDB to follow symlink instead of readlink. Unlike
> 	readlink, GDB is guaranteed to be available.
> 
> Since V1:
> 	- Replace '&>/dev/null' with '>/dev/null 2>&1'
> 
> --
> 
> PR 27614 shows that gdb-add-index fails to generate the index when its
> argument is a symlink.
> 
> The following one liner illustrates the reported problem:
> 
>         $ echo 'int main(){}'|gcc -g -x c -;ln -s a.out symlink;gdb-add-index symlink
>         gdb-add-index: No index was created for symlink
>         gdb-add-index: [Was there no debuginfo? Was there already an index?]
>         $ ls -l
>         -rwxr-xr-x 1 25712 Mar 19 23:05 a.out*
>         -rw------- 1  8277 Mar 19 23:05 a.out.gdb-index
>         lrwxrwxrwx 1     5 Mar 19 23:05 symlink -> a.out*
> 
> GDB generates the .gdb-index file with a name that matches the name of
> the actual program (a.out.gdb-index here), not the symlink that
> references it.  The remaining of the script is looking for a file named
> after the provided argument (would be 'symlink.gdb-index' in our
> example).
> 
> gdb/ChangeLog:
> 
> 	PR gdb/27614
> 	* contrib/gdb-add-index.sh: Fix when called with a symlink as an
> 	argument.
> 
> gdb/testsuite/ChangeLog:
> 
> 	PR gdb/27614
> 	* gdb.dwarf2/gdb-add-index-symlink.exp: New test.

This is ok, thanks!

Simon