From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zhlFOhN7mGAdCwAAWB0awg (envelope-from ) for ; Sun, 09 May 2021 20:15:15 -0400 Received: by simark.ca (Postfix, from userid 112) id E142B1F11C; Sun, 9 May 2021 20:15:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4A6EB1E54D for ; Sun, 9 May 2021 20:15:15 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ACDF33851C16; Mon, 10 May 2021 00:15:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ACDF33851C16 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1620605714; bh=FHNzqzALU67wXT87Hx6Y49VE5GK6KUlLhyMDbs2yvrM=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=EniJalFtT34JGT1iEZ3S0F7qgQTiQsC70gAazG3CCh2eoTQqlEBvUozO7EPNk/7m9 ShHgIVeNcpH3/1kxsuhbq0eipFsUdsL2WeCB2Ckt6EkFcBYuBoBbU0mBgSXAaIwlBz 1o6b2mr0yqF3mSpNhHr4jEgXrCCaoVzGtU9y5tu0= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 86E1E385782C for ; Mon, 10 May 2021 00:15:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 86E1E385782C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 14A0E2gH008157 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 9 May 2021 20:14:08 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 14A0E2gH008157 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 6E5851E54D; Sun, 9 May 2021 20:14:02 -0400 (EDT) Subject: Re: [PATCH v4] [PR gdb/27614] gdb-add-index fails on symlinks. To: Lancelot SIX , gdb-patches@sourceware.org References: <20210329205224.12859-1-lsix@lancelotsix.com> Message-ID: <2697b784-fd81-acb3-c4af-f5a65267c06f@polymtl.ca> Date: Sun, 9 May 2021 20:14:02 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210329205224.12859-1-lsix@lancelotsix.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 10 May 2021 00:14:02 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-03-29 4:52 p.m., Lancelot SIX via Gdb-patches wrote: > Since V3: > - Do net rely on GDB's maintenance commands to resolve > symlinks, revert to using readlink while maximizing portability. > > Since V2: > - Use GDB to follow symlink instead of readlink. Unlike > readlink, GDB is guaranteed to be available. > > Since V1: > - Replace '&>/dev/null' with '>/dev/null 2>&1' > > -- > > PR 27614 shows that gdb-add-index fails to generate the index when its > argument is a symlink. > > The following one liner illustrates the reported problem: > > $ echo 'int main(){}'|gcc -g -x c -;ln -s a.out symlink;gdb-add-index symlink > gdb-add-index: No index was created for symlink > gdb-add-index: [Was there no debuginfo? Was there already an index?] > $ ls -l > -rwxr-xr-x 1 25712 Mar 19 23:05 a.out* > -rw------- 1 8277 Mar 19 23:05 a.out.gdb-index > lrwxrwxrwx 1 5 Mar 19 23:05 symlink -> a.out* > > GDB generates the .gdb-index file with a name that matches the name of > the actual program (a.out.gdb-index here), not the symlink that > references it. The remaining of the script is looking for a file named > after the provided argument (would be 'symlink.gdb-index' in our > example). > > gdb/ChangeLog: > > PR gdb/27614 > * contrib/gdb-add-index.sh: Fix when called with a symlink as an > argument. > > gdb/testsuite/ChangeLog: > > PR gdb/27614 > * gdb.dwarf2/gdb-add-index-symlink.exp: New test. This is ok, thanks! Simon