From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Don't use F_SETFL in gdbreplay
Date: Wed, 12 Aug 2026 11:31:29 -0400 [thread overview]
Message-ID: <25fcd57b-0459-4544-8725-8f7466ad9604@simark.ca> (raw)
In-Reply-To: <20260717-f-setfl-v1-1-0d1eec47cf25@adacore.com>
On 7/17/26 1:07 PM, Tom Tromey wrote:
> There's no need to call fcntl with F_SETFL in gdbreplay, as gdbreplay
> does not use or need SIGIO.
> ---
> gdbserver/gdbreplay.cc | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/gdbserver/gdbreplay.cc b/gdbserver/gdbreplay.cc
> index 4426dc316ec..ba03bf64b67 100644
> --- a/gdbserver/gdbreplay.cc
> +++ b/gdbserver/gdbreplay.cc
> @@ -255,9 +255,6 @@ remote_open (const char *name)
> #endif
> }
>
> -#if defined(F_SETFL) && defined (FASYNC)
> - fcntl (remote_desc_in, F_SETFL, FASYNC);
> -#endif
> remote_desc_out = remote_desc_in;
LGTM, but also it looks like you could drop:
#if HAVE_FCNTL_H
#include <fcntl.h>
#endif
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
next prev parent reply other threads:[~2026-08-12 15:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 17:07 [PATCH 0/2] Two small F_SETFL changes Tom Tromey
2026-07-17 17:07 ` [PATCH 1/2] Don't use F_SETFL in gdbreplay Tom Tromey
2026-08-12 15:31 ` Simon Marchi [this message]
2026-08-12 19:17 ` Tom Tromey
2026-07-17 17:07 ` [PATCH 2/2] Use F_SETFL after F_SETOWN Tom Tromey
2026-08-12 15:34 ` Simon Marchi
2026-08-12 19:17 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25fcd57b-0459-4544-8725-8f7466ad9604@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox