From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7msNGu2RfGryuiAAWB0awg (envelope-from ) for ; Wed, 12 Aug 2026 11:31:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1786548717; bh=NskSetJt/J94LFUczluv9z7leuA8/b/foiqR9gbgh2o=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=N50I8km+pC4HvJOTUg9lrPikSFEbGcnw/mQPxj+RR2PLjq3wpDBb1SVclYwWbLRyr AEnOGd/0eN06zt5EQW6U0r7uOUB/c7tDqcSnwCnZO6QNdo/DO5MmmOvGqdUirsOe6D LEWjg07AISjMRYY8KKew+A+Ep4ZZJmLqQPI1i40s= Received: by simark.ca (Postfix, from userid 112) id 564801E09B; Wed, 12 Aug 2026 11:31:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=AqhWxtBm; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C14A51E09B for ; Wed, 12 Aug 2026 11:31:56 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5365F4BB24F6 for ; Wed, 12 Aug 2026 15:31:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5365F4BB24F6 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=AqhWxtBm Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 93F2D4BA2E09 for ; Wed, 12 Aug 2026 15:31:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 93F2D4BA2E09 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 93F2D4BA2E09 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786548692; cv=none; b=A/vd2l/m0IeZ66XSMjpuq92TduciVsxH2jOt9uFhtOfg3ijLYa0TFVHB/K3Dy3YfFnPY08IkNnXzdokhqJzutnUIct4Nj1WY5om/SxHjap16lHtPjzQFHpMyorlTHgudZxsFpwWAn9lfrPb1ngseD/gqFfz5UkSF2zuOUA872LY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786548692; c=relaxed/simple; bh=NskSetJt/J94LFUczluv9z7leuA8/b/foiqR9gbgh2o=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=F5dA3M0UWaBjLmOPeLLNeYLXeiK5bhIqwR0Tmx11Fq7YE3jZzXsYRCY9dkOr9Ms5baRG6SvxOFBFazqRZ5S+n89Y6TAwI3vOvwgBXBDpoq+LQiFfHo5EtrU/LTwX5KPzPjMjKQiu+UUo+Z9aZNpXVak1dBq7VZ3k6WpLBpW7BJc= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=AqhWxtBm DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 93F2D4BA2E09 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1786548690; bh=NskSetJt/J94LFUczluv9z7leuA8/b/foiqR9gbgh2o=; h=Date:Subject:To:References:From:In-Reply-To:From; b=AqhWxtBmfZop16Ndy9FIm3nT9WH3HobE/BDT4Z1vkZ/ooFi1l0EXwPCd5SP3nuFsd 3ErvBg/uIiv7I7eMe5WrXxmH1zIZcqDMoTzX2IS9uIaRw2h30vV1kbKZzxO1YysZwM OPAWakchRKfQFhoB3SxEHp3NNDoetcXG+LXb5hz4= Received: by simark.ca (Postfix) id B2A531E09B; Wed, 12 Aug 2026 11:31:29 -0400 (EDT) Message-ID: <25fcd57b-0459-4544-8725-8f7466ad9604@simark.ca> Date: Wed, 12 Aug 2026 11:31:29 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] Don't use F_SETFL in gdbreplay To: Tom Tromey , gdb-patches@sourceware.org References: <20260717-f-setfl-v1-0-0d1eec47cf25@adacore.com> <20260717-f-setfl-v1-1-0d1eec47cf25@adacore.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20260717-f-setfl-v1-1-0d1eec47cf25@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 7/17/26 1:07 PM, Tom Tromey wrote: > There's no need to call fcntl with F_SETFL in gdbreplay, as gdbreplay > does not use or need SIGIO. > --- > gdbserver/gdbreplay.cc | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/gdbserver/gdbreplay.cc b/gdbserver/gdbreplay.cc > index 4426dc316ec..ba03bf64b67 100644 > --- a/gdbserver/gdbreplay.cc > +++ b/gdbserver/gdbreplay.cc > @@ -255,9 +255,6 @@ remote_open (const char *name) > #endif > } > > -#if defined(F_SETFL) && defined (FASYNC) > - fcntl (remote_desc_in, F_SETFL, FASYNC); > -#endif > remote_desc_out = remote_desc_in; LGTM, but also it looks like you could drop: #if HAVE_FCNTL_H #include #endif Approved-By: Simon Marchi Simon