From: "Eli Zaretskii" <eliz@is.elta.co.il>
To: tromey@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFC: Inferior command line arguments
Date: Fri, 28 Sep 2001 01:31:00 -0000 [thread overview]
Message-ID: <2593-Fri28Sep2001103201+0300-eliz@is.elta.co.il> (raw)
In-Reply-To: <87zo7gq7gb.fsf@creche.redhat.com>
> From: Tom Tromey <tromey@redhat.com>
> Date: 27 Sep 2001 22:12:52 -0600
[Shouldn't this kind of discussions be held on gdb rather than
gdb-patches?]
> What I'm looking for is some assurance that this approach isn't just a
> waste of time. Also, advice on nonobvious things is useful
Thanks.
I think this is a good approach. I have a couple of comments.
First, isn't it better to use quoteargs (sp?) function for the quoting
of the characters special to the shell, instead of rolling our own? I
mean the function which is used by Patch and a few other GNU packages.
> +/* Given a vector of command-line arguments, return a newly allocated
> + string which, when passed to the create_inferior function, will be
> + parsed to yield the same vector.
I'm probably missing something important here, but this comment begs a
question: if all we need is to get the same vector in the end, why go
through the pain of quoting it and then unquoting it again? Can't we
just sneak the original vector in somehow?
next prev parent reply other threads:[~2001-09-28 1:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-27 21:02 Tom Tromey
2001-09-28 1:31 ` Eli Zaretskii [this message]
2001-09-28 5:26 ` Tom Tromey
2001-09-28 7:21 ` Eli Zaretskii
2001-09-28 7:50 ` Tom Tromey
2001-09-28 9:25 ` Eli Zaretskii
2001-09-30 12:07 ` Christopher Faylor
2001-10-01 0:39 ` Eli Zaretskii
2001-10-01 8:07 ` Tom Tromey
2001-10-01 8:10 ` Christopher Faylor
2001-09-28 11:24 ` Michael Snyder
2001-09-28 11:32 ` Tom Tromey
2001-09-28 11:59 ` Daniel Jacobowitz
2001-09-28 12:24 ` Tom Tromey
2001-09-29 2:23 ` Eli Zaretskii
2001-09-28 12:27 ` Andrew Cagney
2001-09-28 12:42 ` Daniel Jacobowitz
2001-09-28 14:19 ` Tom Tromey
2001-09-28 14:22 ` Daniel Jacobowitz
2001-09-29 1:23 ` David Deephanphongs
2001-10-01 8:09 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2593-Fri28Sep2001103201+0300-eliz@is.elta.co.il \
--to=eliz@is.elta.co.il \
--cc=gdb-patches@sources.redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox