From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eli Zaretskii" To: tromey@redhat.com Cc: gdb-patches@sources.redhat.com Subject: Re: RFC: Inferior command line arguments Date: Fri, 28 Sep 2001 01:31:00 -0000 Message-id: <2593-Fri28Sep2001103201+0300-eliz@is.elta.co.il> References: <87zo7gq7gb.fsf@creche.redhat.com> X-SW-Source: 2001-09/msg00410.html > From: Tom Tromey > Date: 27 Sep 2001 22:12:52 -0600 [Shouldn't this kind of discussions be held on gdb rather than gdb-patches?] > What I'm looking for is some assurance that this approach isn't just a > waste of time. Also, advice on nonobvious things is useful Thanks. I think this is a good approach. I have a couple of comments. First, isn't it better to use quoteargs (sp?) function for the quoting of the characters special to the shell, instead of rolling our own? I mean the function which is used by Patch and a few other GNU packages. > +/* Given a vector of command-line arguments, return a newly allocated > + string which, when passed to the create_inferior function, will be > + parsed to yield the same vector. I'm probably missing something important here, but this comment begs a question: if all we need is to get the same vector in the end, why go through the pain of quoting it and then unquoting it again? Can't we just sneak the original vector in somehow?