Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: msnyder@sonic.net
To: "Nick Roberts" <nickrob@snap.net.nz>
Cc: msnyder@sonic.net, gdb-patches@sourceware.org
Subject: Re: [PATCH] varobj.c, value_of_root, (another) memory leak
Date: Fri, 17 Aug 2007 23:21:00 -0000	[thread overview]
Message-ID: <25573.12.7.175.2.1187392872.squirrel@webmail.sonic.net> (raw)
In-Reply-To: <18109.5009.554826.719365@kahikatea.snap.net.nz>

>  > I'm not totally sure about this -- does the return value of
> var_get_type
>  > need to be freed?  If so, there are some other places in mi-cmd-var
>  > where it isn't being.
>
> Yes, I think this is right but USE_SELECTED_FRAME is broken anyway.  The
> ones in mi-cmd-var.c may be more important.  Similar problems seem to
> occur with varobj_get_expression and varobj_get_value.

Committed.



      parent reply	other threads:[~2007-08-17 23:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-10 23:01 msnyder
2007-08-11  1:40 ` Nick Roberts
2007-08-11  2:41   ` Daniel Jacobowitz
2007-08-11 20:10     ` msnyder
2007-08-17 23:21   ` msnyder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25573.12.7.175.2.1187392872.squirrel@webmail.sonic.net \
    --to=msnyder@sonic.net \
    --cc=gdb-patches@sourceware.org \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox