From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1211 invoked by alias); 17 Aug 2007 23:21:28 -0000 Received: (qmail 1169 invoked by uid 22791); 17 Aug 2007 23:21:27 -0000 X-Spam-Check-By: sourceware.org Received: from a.mail.sonic.net (HELO a.mail.sonic.net) (64.142.16.245) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 17 Aug 2007 23:21:26 +0000 Received: from webmail.sonic.net (b.webmail.sonic.net [64.142.100.148]) by a.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with ESMTP id l7HNLB8c001690; Fri, 17 Aug 2007 16:21:12 -0700 Received: from 12.7.175.2 (SquirrelMail authenticated user msnyder) by webmail.sonic.net with HTTP; Fri, 17 Aug 2007 16:21:12 -0700 (PDT) Message-ID: <25573.12.7.175.2.1187392872.squirrel@webmail.sonic.net> In-Reply-To: <18109.5009.554826.719365@kahikatea.snap.net.nz> References: <16480.12.7.175.2.1186786910.squirrel@webmail.sonic.net> <18109.5009.554826.719365@kahikatea.snap.net.nz> Date: Fri, 17 Aug 2007 23:21:00 -0000 Subject: Re: [PATCH] varobj.c, value_of_root, (another) memory leak From: msnyder@sonic.net To: "Nick Roberts" Cc: msnyder@sonic.net, gdb-patches@sourceware.org User-Agent: SquirrelMail/1.4.9a MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00344.txt.bz2 > > I'm not totally sure about this -- does the return value of > var_get_type > > need to be freed? If so, there are some other places in mi-cmd-var > > where it isn't being. > > Yes, I think this is right but USE_SELECTED_FRAME is broken anyway. The > ones in mi-cmd-var.c may be more important. Similar problems seem to > occur with varobj_get_expression and varobj_get_value. Committed.