From: Mike Frysinger <vapier@gentoo.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org, Doug Evans <dje@google.com>,
Joel Sherrill <joel.sherrill@oarcorp.com>
Subject: Re: Fix spelling error in psim
Date: Thu, 21 Aug 2014 08:12:00 -0000 [thread overview]
Message-ID: <2490490.02THBj8e9v@vapier> (raw)
In-Reply-To: <20140821071535.GK1773@adacore.com>
[-- Attachment #1: Type: text/plain, Size: 1522 bytes --]
On Thu 21 Aug 2014 09:15:35 Joel Brobecker wrote:
> > > [If this were gdb one might want a "." followed by two spaces here,
> > > but this isn't gdb. Lucky you. :-)]
> >
> > that's enforced in new code (which psim is anything but). i'd have no
> > problem if someone felt like going through and cleaning that
> > particular issue up in the whole code base.
> >
> > sim should be following GNU style conventions. i dislike them, but
> > it's part of a larger GNU project, so deviating anyways would be bad
> > form :).
>
> Interestingly, I have always considered sim to be part of the GDB
> project, and therefore under GDB coding style.
aren't they the same thing ? i guess let's see.
gdb/CONTRIBUTE says:
o Coding Standards
All contributions must conform to the GNU Coding Standard.
Submissions which do not conform to the standards will be
returned with a request to reformat the changes.
which is what i thought ... but then there's this follow up:
GDB has certain additional coding requirements. Those
requirements are explained in the GDB internals documentation
in the gdb/doc directory.
except there's no gdbint.texinfo anymore. let's check the website:
https://www.gnu.org/software/gdb/documentation/
GDB Internals Manual (wiki only)
https://sourceware.org/gdb/wiki/InternalsManual
https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards
ok, i guess there's a few more rules here. having the sim follow those is
fine.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-08-21 8:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 22:45 Joel Sherrill
2014-08-21 0:10 ` Doug Evans
2014-08-21 1:14 ` Mike Frysinger
2014-08-21 7:15 ` Joel Brobecker
2014-08-21 8:12 ` Mike Frysinger [this message]
2014-08-21 13:46 ` Joel Sherrill
2014-08-27 6:08 ` Joel Brobecker
2014-08-21 1:13 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2490490.02THBj8e9v@vapier \
--to=vapier@gentoo.org \
--cc=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=joel.sherrill@oarcorp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox