From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7310 invoked by alias); 21 Aug 2014 08:12:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7295 invoked by uid 89); 21 Aug 2014 08:12:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 21 Aug 2014 08:12:40 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 6F25534003D; Thu, 21 Aug 2014 08:12:38 +0000 (UTC) From: Mike Frysinger To: Joel Brobecker Cc: gdb-patches@sourceware.org, Doug Evans , Joel Sherrill Subject: Re: Fix spelling error in psim Date: Thu, 21 Aug 2014 08:12:00 -0000 Message-ID: <2490490.02THBj8e9v@vapier> User-Agent: KMail/4.13.3 (Linux/3.14.2; KDE/4.13.3; x86_64; ; ) In-Reply-To: <20140821071535.GK1773@adacore.com> References: <53F5250D.4030301@oarcorp.com> <6224461.lknybP5UIy@vapier> <20140821071535.GK1773@adacore.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1782211.zyfcZAW8Uu"; micalg="pgp-sha1"; protocol="application/pgp-signature" X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00467.txt.bz2 --nextPart1782211.zyfcZAW8Uu Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" Content-length: 1497 On Thu 21 Aug 2014 09:15:35 Joel Brobecker wrote: > > > [If this were gdb one might want a "." followed by two spaces here, > > > but this isn't gdb. Lucky you. :-)] > >=20 > > that's enforced in new code (which psim is anything but). i'd have no > > problem if someone felt like going through and cleaning that > > particular issue up in the whole code base. > >=20 > > sim should be following GNU style conventions. i dislike them, but > > it's part of a larger GNU project, so deviating anyways would be bad > > form :). >=20 > Interestingly, I have always considered sim to be part of the GDB > project, and therefore under GDB coding style. aren't they the same thing ? i guess let's see. gdb/CONTRIBUTE says: o Coding Standards All contributions must conform to the GNU Coding Standard. Submissions which do not conform to the standards will be returned with a request to reformat the changes. which is what i thought ... but then there's this follow up: GDB has certain additional coding requirements. Those requirements are explained in the GDB internals documentation in the gdb/doc directory. except there's no gdbint.texinfo anymore. let's check the website: https://www.gnu.org/software/gdb/documentation/ GDB Internals Manual (wiki only) https://sourceware.org/gdb/wiki/InternalsManual https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards ok, i guess there's a few more rules here. having the sim follow those is= =20 fine. -mike= --nextPart1782211.zyfcZAW8Uu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABAgAGBQJT9an2AAoJEEFjO5/oN/WBITAP/jBpiXyuY5GcH8wn2B007m5H uXJXnKlq7kIlsZ/RvJMd8qeuU8q+W9QGc8+Vj6Xk9CStQYMofiWpAc9FH6RHAv9d 6am9A90cId4xAXgTpHZb8+bp3jUhODTF9CDd93JcSeaAZuSY12il7/V0YlAj/d3R /YPHJBnzIdpmnK30DQHIaYsfVad4kMk0mLH6+2Cse9W4BNauiGvsSNpw0nSiWZbO sYk3tXGBnnsD41u8qFe4qX9jSEZeRC2ZAlnHwXglwvfBn8iojgoSK//7ViVzPxh3 pMVTLaVsQs/XaoFFjGKgyYrfDDQ0XnLXdhx+8LLvG/0hQV2ntXa96aqP1C4oNk6C yvvTIG1sjt7WZ9hovLhemW3YP8tfVyyk0DDPXDXUd/zD3S82UVkHBpfF383OCwFM 5SsbjBBev6LqVE7P6IX+WFN03neQaJfNODw+GqFYVzriOP6DWSJA2YLuRFb6Nvph WmpkecD5+JQreg+osdL80EfsJ0uKIVC9PMJ6oOlfVPxV/jopxpDYo6k3Rf6xeYGw cY3Ws6QEdjQj+dD+ZafcSRvwLB+11w3CiCGA7BM6WfmadaW954iXJw0INcKWwVrD XJo0V7dJhD1s8lYc8u3S7I4oHsrSeLDc8sPgP/a8RAjhyUHczE6bgntLov779OAh ajQJfr9In4m0YAPKkoX+ =s5ia -----END PGP SIGNATURE----- --nextPart1782211.zyfcZAW8Uu--