From: "Mark Kettenis" <mark.kettenis@xs4all.nl>
To: "Vladimir Prus" <vladimir@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] zero-terminate result of target_read_alloc
Date: Tue, 18 Jul 2006 11:25:00 -0000 [thread overview]
Message-ID: <24758.192.87.1.22.1153221922.squirrel@webmail.xs4all.nl> (raw)
In-Reply-To: <200607181356.16071.vladimir@codesourcery.com>
>
> This patch makes result of target_read_alloc zero-terminated.
> The point is that often the object is not allowed to contain embedded
> zeros,
> and working with zero-terminated strings is much easier.
>
> OK?
This is wrong. Either the terminating nul is part of the object you're
reading or it is not. GDB shouldn't at its own.
>
> - Volodya
>
> 2006-07-18 Vladimir Prus <vladimir@codesourcery.com>
>
> * target.c (target_read_alloc): Zero-terminate result.
>
>
next prev parent reply other threads:[~2006-07-18 11:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-18 9:56 Vladimir Prus
2006-07-18 11:25 ` Mark Kettenis [this message]
2006-07-18 11:33 ` Vladimir Prus
2006-07-18 12:34 ` Daniel Jacobowitz
2006-07-18 13:15 ` Mark Kettenis
2006-07-18 13:39 ` Daniel Jacobowitz
2006-07-18 13:51 ` Vladimir Prus
2006-07-18 19:51 ` Jim Blandy
2006-07-24 4:09 ` Daniel Jacobowitz
2006-07-24 21:41 ` Mark Kettenis
2006-07-24 22:00 ` Daniel Jacobowitz
2006-07-26 21:53 ` Mark Kettenis
2006-07-26 22:25 ` Daniel Jacobowitz
2006-07-26 22:36 ` Mark Kettenis
2006-07-27 21:25 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24758.192.87.1.22.1153221922.squirrel@webmail.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sources.redhat.com \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox