From: Vladimir Prus <vladimir@codesourcery.com>
To: "Mark Kettenis" <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] zero-terminate result of target_read_alloc
Date: Tue, 18 Jul 2006 11:33:00 -0000 [thread overview]
Message-ID: <200607181533.01309.vladimir@codesourcery.com> (raw)
In-Reply-To: <24758.192.87.1.22.1153221922.squirrel@webmail.xs4all.nl>
On Tuesday 18 July 2006 15:25, Mark Kettenis wrote:
> > This patch makes result of target_read_alloc zero-terminated.
> > The point is that often the object is not allowed to contain embedded
> > zeros,
> > and working with zero-terminated strings is much easier.
> >
> > OK?
>
> This is wrong. Either the terminating nul is part of the object you're
> reading or it is not. GDB shouldn't at its own.
I'm sorry, I don't understand the problem. Some objects are binary in nature,
can contain zeroes, and should be manipulated using length.
Some objects, for example XML memory map, are text ones. Embedded zero byte in
such object is bug in remote side, and nothing else. And while it would not
be overly complicate to pass length of such objects in my case, I don't see
why we should impose this complication on everybody.
- Volodya
next prev parent reply other threads:[~2006-07-18 11:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-18 9:56 Vladimir Prus
2006-07-18 11:25 ` Mark Kettenis
2006-07-18 11:33 ` Vladimir Prus [this message]
2006-07-18 12:34 ` Daniel Jacobowitz
2006-07-18 13:15 ` Mark Kettenis
2006-07-18 13:39 ` Daniel Jacobowitz
2006-07-18 13:51 ` Vladimir Prus
2006-07-18 19:51 ` Jim Blandy
2006-07-24 4:09 ` Daniel Jacobowitz
2006-07-24 21:41 ` Mark Kettenis
2006-07-24 22:00 ` Daniel Jacobowitz
2006-07-26 21:53 ` Mark Kettenis
2006-07-26 22:25 ` Daniel Jacobowitz
2006-07-26 22:36 ` Mark Kettenis
2006-07-27 21:25 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607181533.01309.vladimir@codesourcery.com \
--to=vladimir@codesourcery.com \
--cc=gdb-patches@sources.redhat.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox