From: Keith Seitz via Gdb-patches <gdb-patches@sourceware.org>
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Fix "b f(std::string)", always use DMGL_VERBOSE
Date: Thu, 5 May 2022 13:31:28 -0700 [thread overview]
Message-ID: <23464c69-1958-38ba-b4fb-3cd6c70a0e23@redhat.com> (raw)
In-Reply-To: <20220505185020.3648774-2-pedro@palves.net>
On 5/5/22 11:50, Pedro Alves wrote:
> Currently, on any remotely modern GNU/Linux system,
> gdb.cp/no-dmgl-verbose.exp fails like so:
[snip]
What an amazingly complete history of this. Thank you!
> Change-Id: Ib54fab4cf0fd307bfd55bf1dd5056830096a653b
> ---
> gdb/cp-name-parser.y | 5 +-
> gdb/cp-support.c | 44 +++++---
> gdb/cp-support.h | 12 ++
> ...-dmgl-verbose.cc => break-f-std-string.cc} | 0
> gdb/testsuite/gdb.cp/break-f-std-string.exp | 105 ++++++++++++++++++
> gdb/testsuite/gdb.cp/no-dmgl-verbose.exp | 35 ------
> 6 files changed, 147 insertions(+), 54 deletions(-)
> rename gdb/testsuite/gdb.cp/{no-dmgl-verbose.cc => break-f-std-string.cc} (100%)
> create mode 100644 gdb/testsuite/gdb.cp/break-f-std-string.exp
> delete mode 100644 gdb/testsuite/gdb.cp/no-dmgl-verbose.exp
I see nothing to make me pause. I think you should approve your patch.
Keith
next prev parent reply other threads:[~2022-05-05 20:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 18:50 [PATCH 0/3] Fix "b func(std::string)", DMGL_VERBOSE, gdb.cp/no-dmgl-verbose.exp Pedro Alves
2022-05-05 18:50 ` [PATCH 1/3] Fix "b f(std::string)", always use DMGL_VERBOSE Pedro Alves
2022-05-05 20:31 ` Keith Seitz via Gdb-patches [this message]
2022-05-05 21:49 ` Carl Love via Gdb-patches
2022-05-06 13:21 ` Pedro Alves
2022-05-06 8:10 ` Lancelot SIX via Gdb-patches
2022-05-06 13:09 ` Pedro Alves
2022-05-05 18:50 ` [PATCH 2/3] Always pass an explicit language down to c_type_print Pedro Alves
2022-05-05 20:47 ` Keith Seitz via Gdb-patches
2022-05-06 12:33 ` Pedro Alves
2022-05-05 18:50 ` [PATCH 3/3] Fix "b f(std::string)" when current language is C Pedro Alves
2022-05-05 20:50 ` Keith Seitz via Gdb-patches
2022-05-06 8:34 ` Lancelot SIX via Gdb-patches
2022-05-06 13:09 ` Pedro Alves
2022-05-09 16:54 ` [PATCH 0/3] Fix "b func(std::string)", DMGL_VERBOSE, gdb.cp/no-dmgl-verbose.exp Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23464c69-1958-38ba-b4fb-3cd6c70a0e23@redhat.com \
--to=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox