Re: [PATCH 1/3] Fix "b f(std::string)", always use DMGL_VERBOSE

[Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org>]

Hi,

I have minor comments inlined below.

> [...]
>
> When the libiberty demangler encounters such a abbreviation, by
> default, it expands it to the user-friendly typedef "std::string",
> "std::iostream", etc..  If OTOH DMGL_VERBOSE is specified, the
> abbreviation is expanded to the underlying, non-typeded fullname

s/non-typeded/non-typedefed/ ?

> [...]
> 
> Now, if DMGL_VERBOSE is _not_ used, then the demangler demangles the
> mangled name of a function such as "void f(std::string)" thas was

s/thas/that/

> diff --git a/gdb/cp-name-parser.y b/gdb/cp-name-parser.y
> index 6410363c87f..ceb4c968935 100644
> --- a/gdb/cp-name-parser.y
> +++ b/gdb/cp-name-parser.y
> @@ -1959,8 +1959,7 @@ cp_comp_to_string (struct demangle_component *result, int estimated_len)

The comment for this function is:

    /* Convert RESULT to a string.  The return value is allocated
       using xmalloc.  ESTIMATED_LEN is used only as a guide to the
       length of the result.  This functions handles a few cases that
       cplus_demangle_print does not, specifically the global destructor
       and constructor labels.  */

The last sentence (which references cplus_demangle_print) is not
accurate anymore.  This was out of sync before your change, but while at
it, do you mind updating the comment?

>  {
>    size_t err;
>  
> -  char *res = cplus_demangle_print (DMGL_PARAMS | DMGL_ANSI,
> -				    result, estimated_len, &err);
> +  char *res = gdb_cplus_demangle_print (result, estimated_len, &err);
>    return gdb::unique_xmalloc_ptr<char> (res);
>  }

Best,
Lancelot.