From: Simon Marchi <simon.marchi@polymtl.ca>
To: "Maciej W. Rozycki" <macro@imgtec.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [committed] testsuite: solib-disc: Use `standard_output_file'
Date: Thu, 06 Oct 2016 15:01:00 -0000 [thread overview]
Message-ID: <22969fb9beb08775c70e452df7bc1def@simark.ca> (raw)
In-Reply-To: <alpine.DEB.2.00.1610061506120.31859@tp.orcam.me.uk>
On 2016-10-06 10:17, Maciej W. Rozycki wrote:
> Correct a commit 2151ccc56c74 ("Always organize test artifacts in a
> directory hierarchy") regression causing:
>
> Running .../gdb/testsuite/gdb.base/solib-disc.exp ...
> gdb compile failed, Assembler messages:
> Fatal error: can't create .../gdb/testsuite/gdb.base/so-disc-shr.c.o:
> No such file or directory
>
> by using `standard_output_file' to construct output file names
> throughout.
>
> gdb/testsuite/
> * gdb.base/solib-disc.exp: Use `standard_output_file'
> throughout.
> ---
> Tested with `mips-mti-linux-gnu':
>
> Running .../gdb/testsuite/gdb.base/solib-disc.exp ...
> PASS: gdb.base/solib-disc.exp: set stop-on-solib-events 1
> PASS: gdb.base/solib-disc.exp: continue to load
> PASS: gdb.base/solib-disc.exp: save $pc after load
> PASS: gdb.base/solib-disc.exp: disconnect after load
> PASS: gdb.base/solib-disc.exp: reconnect after load
> PASS: gdb.base/solib-disc.exp: check $pc after load
> PASS: gdb.base/solib-disc.exp: continue to unload
> PASS: gdb.base/solib-disc.exp: save $pc after unload
> PASS: gdb.base/solib-disc.exp: disconnect after unload
> PASS: gdb.base/solib-disc.exp: reconnect after unload
> PASS: gdb.base/solib-disc.exp: check $pc after unload
>
> and committed as obvious.
>
> Maciej
Good catch! I probably hadn't tested the patch with gdbserver...
Did you consider using standard_testfile to define the usual testfile,
srcfile and binfile?
next prev parent reply other threads:[~2016-10-06 15:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 14:18 Maciej W. Rozycki
2016-10-06 15:01 ` Simon Marchi [this message]
2016-10-06 15:19 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22969fb9beb08775c70e452df7bc1def@simark.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=macro@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox