From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97948 invoked by alias); 6 Oct 2016 15:01:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 97904 invoked by uid 89); 6 Oct 2016 15:01:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=H*r:112 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Oct 2016 15:01:35 +0000 Received: by simark.ca (Postfix, from userid 112) id 82EDC1E487; Thu, 6 Oct 2016 11:01:33 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id D8B7C1E052; Thu, 6 Oct 2016 11:01:32 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 06 Oct 2016 15:01:00 -0000 From: Simon Marchi To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org Subject: Re: [committed] testsuite: solib-disc: Use `standard_output_file' In-Reply-To: References: Message-ID: <22969fb9beb08775c70e452df7bc1def@simark.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.0 X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg00125.txt.bz2 On 2016-10-06 10:17, Maciej W. Rozycki wrote: > Correct a commit 2151ccc56c74 ("Always organize test artifacts in a > directory hierarchy") regression causing: > > Running .../gdb/testsuite/gdb.base/solib-disc.exp ... > gdb compile failed, Assembler messages: > Fatal error: can't create .../gdb/testsuite/gdb.base/so-disc-shr.c.o: > No such file or directory > > by using `standard_output_file' to construct output file names > throughout. > > gdb/testsuite/ > * gdb.base/solib-disc.exp: Use `standard_output_file' > throughout. > --- > Tested with `mips-mti-linux-gnu': > > Running .../gdb/testsuite/gdb.base/solib-disc.exp ... > PASS: gdb.base/solib-disc.exp: set stop-on-solib-events 1 > PASS: gdb.base/solib-disc.exp: continue to load > PASS: gdb.base/solib-disc.exp: save $pc after load > PASS: gdb.base/solib-disc.exp: disconnect after load > PASS: gdb.base/solib-disc.exp: reconnect after load > PASS: gdb.base/solib-disc.exp: check $pc after load > PASS: gdb.base/solib-disc.exp: continue to unload > PASS: gdb.base/solib-disc.exp: save $pc after unload > PASS: gdb.base/solib-disc.exp: disconnect after unload > PASS: gdb.base/solib-disc.exp: reconnect after unload > PASS: gdb.base/solib-disc.exp: check $pc after unload > > and committed as obvious. > > Maciej Good catch! I probably hadn't tested the patch with gdbserver... Did you consider using standard_testfile to define the usual testfile, srcfile and binfile?