From: Simon Marchi <simon.marchi@efficios.com>
To: Guinevere Larsen <guinevere@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/record-full: make record_full_arch_list_add take an rvalue ref
Date: Tue, 7 Jul 2026 14:56:14 -0400 [thread overview]
Message-ID: <2209068f-c629-47ff-b16e-a5615db0fc2b@efficios.com> (raw)
In-Reply-To: <0f8bd92f-7940-4faa-b5a8-7bd67f0a94f5@redhat.com>
On 7/7/26 2:54 PM, Guinevere Larsen wrote:
> On 7/6/26 1:40 PM, Simon Marchi wrote:
>> record_full_arch_list_add moves its `rec` argument, so it should take an
>> rvalue ref to reflect that. Otherwise the fact that the object is moved
>> from can be a "surprise" to the callers.
>>
>> Change-Id: Ibeb56b1523ad8aee077d3bc3cad1f00d6b47ea2f
>> ---
>
> Yeah, this makes sense, and feels pretty straightforward
>
> Approved-By: Guinevere Larsen <guinevere@redhat.com>
Thanks, pushed.
Simon
prev parent reply other threads:[~2026-07-07 18:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 16:40 Simon Marchi
2026-07-07 18:54 ` Guinevere Larsen
2026-07-07 18:56 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2209068f-c629-47ff-b16e-a5615db0fc2b@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
--cc=guinevere@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox