From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0H48Mv9LTWprXCsAWB0awg (envelope-from ) for ; Tue, 07 Jul 2026 14:57:03 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=rjh1i/ad; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AA4261E098; Tue, 07 Jul 2026 14:57:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8BA2E1E024 for ; Tue, 07 Jul 2026 14:57:02 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EF5084BA23EE for ; Tue, 7 Jul 2026 18:57:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EF5084BA23EE Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=rjh1i/ad Received: from YT6PR01CU002.outbound.protection.outlook.com (mail-canadacentralazon11022093.outbound.protection.outlook.com [40.107.193.93]) by sourceware.org (Postfix) with ESMTPS id 86E614BA23C5 for ; Tue, 7 Jul 2026 18:56:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 86E614BA23C5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 86E614BA23C5 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=40.107.193.93 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783450584; cv=pass; b=TOe8mra+kWPSBwZRifL7/Nk4VRnaQIKFOcOxfXDv17mdpQef0fviwoOJbFGQTwny4rvzUI0257wWd3IgI1RZR/5s0hW8TQz3A66WclylaXrUcBAkHLzAns2/YFdr7pY3HIZ8OLwxctJsXDzwa9ep7/U5E+B9ya/9M154a69tAjE= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783450584; c=relaxed/simple; bh=87a5IdxIACrkmEOUjHS5rqUIvB3NBIhc2e+8LQ4cEVc=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=UXd+vtPCuY7Fdw5o6A4Ky/oi2L09umHKFnPlznbMdw0/zownVC7NQTwzgCSQ2q4cMAAxxaZuYXlkht9ie2+X/8rYAUsdv8XEcvmGnbunqHCT6ZlaDawq+ixn4WeIJ+JqRNhC5TE2vJpSHc8frGiV8v929ZAXILchiIQ035fss44= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=rjh1i/ad DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 86E614BA23C5 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Yj4O128hOm0SlMm3ki4Kqdx5Jm0ZAP+KS888Pw+7SsARH+mvBaaOx+Zt6dA0ik0dwrasfHX26RKaZUZmmXzLPNOeIcoUApDWDxYA2VcbU/8vv+h2ifva4CIodNKWN3DbUaW2LLrRPqnr7SKAjG7HYnxCYSOhIboUOUEiSsZ6NGXu0z1apt9Yq+WCiQPuNArQ/dXhoWQgggE5bISRAkP5ZMKkBaiY8f5wiutMaekhGB/mmzad9iY+prMpz3JRBmKKc52ZMuImUqEXvvjFeXlBafDE8WGuF34udTo/r+fBGxKYlKOEPUUeG87n8wmQ4PH+xblihJ8w3kQeVjdEnsh+nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sqXnPXT0V4BryDLiJWiixZvLxgWKuE8DgXQANaJ6sGM=; b=QXjc543vgPnPrQvv1t11NIBS2EByCZnLVVFZa54n+sMvFf/8OVahsF9Jo+vFfai8xEG9ZblhMovjpkVgBA1cUZeQnHywH+AUXBSDj1OJN3Iv7jKLMXORTf/08FLBLKrO9pFns7Y45pIxAa3aEa5Ld1WyGd4vyqFuybrXj1xh7QzmGCGu7z3NHDe/4JzFiljQWHQnaPuj7fJiflCspFE0YX9O8RkUbL72eQK6c8wOJe3JJPjiVJ5EwJb5imptwWLGoosDv/NTMI3u24ZD9S5iZjYbRLLNtgbm/dbI7SD5Kc/u5v44F5mf1m6OPPkT7g7DnpumMD/t5Y+WBjuA7CNu1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sqXnPXT0V4BryDLiJWiixZvLxgWKuE8DgXQANaJ6sGM=; b=rjh1i/ad9TJKGItU6DZd+ruOca5abbkl1IFHwJ8NlfE+ArhqtA+P+ojil2hkUCpOC5cacnXjWzKfBn94pgaWbRoG8uhBRewWuBS8FCeKPz4NzDwI17x0SCq1LsGrPzAYYfL1g3xAIQ13pbr/+uzj2m7wRWk8HJFXpmoKvGTFwRX2PK+0YZWzNt42EfQMlNKgMjdCxTBQZkgNcCg0lOM15cDQVWLWzfSV5t0vy3ZyaDIGFRDW2wqu4G31JgeZmI8YiONGfskvPJLK/x9Yaqtt6I8QRiLreStAqI0TYJZU4E2rGOLnZRfoTQog8pARKu6Ehb3xxf5atZB4P3qfJIBD5A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YT1PPF35D7F4F9F.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b08::523) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.14; Tue, 7 Jul 2026 18:56:16 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%7]) with mapi id 15.21.0181.009; Tue, 7 Jul 2026 18:56:15 +0000 Message-ID: <2209068f-c629-47ff-b16e-a5615db0fc2b@efficios.com> Date: Tue, 7 Jul 2026 14:56:14 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/record-full: make record_full_arch_list_add take an rvalue ref To: Guinevere Larsen , gdb-patches@sourceware.org References: <20260706164012.507674-1-simon.marchi@efficios.com> <0f8bd92f-7940-4faa-b5a8-7bd67f0a94f5@redhat.com> Content-Language: fr From: Simon Marchi In-Reply-To: <0f8bd92f-7940-4faa-b5a8-7bd67f0a94f5@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0174.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:f::17) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YT1PPF35D7F4F9F:EE_ X-MS-Office365-Filtering-Correlation-Id: 841453ee-903a-4301-0086-08dedc596bf3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|10070799003|23010399003|376014|366016|1800799024|4143699003|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: kkSxZf0Wj5UwkJp4+LB7lfDguGgLS1ZkC2UV4MU9dHM8GB8Z8Si823ftsmSi6uF2B2HBlDGvBS9MHtdLKAta+GQNCEfcRvgoMsm5ZuiZcjL8p0HKcxeSmIRXyvLJ1xB7yZEpzwkEFN4leQGmY4RBzKriwynI1QDcgWHscoMEwKiNi94AsbcjrWVw38kGKm184aBX6ekAhQ5kUNii8clmr9Rpyjj/BBo7ot17diN8cw6KQZyNFVPFVeV97VOIGglpuF8OKo24Bu9BOFmLwSUluUWTV6yHte80+cpuJy9kcYC4zffUcCpyCPYTM++5GTOulzHRmTA/2atmApvGZQppx1zHqMsDgtiJC1Ou0uRiJTmKGe1FWcGZ+ntMuOL4G3aFHo729XhnkjOvCHU4HooaFV2OMLrndKUULOdGn3q7v+ufmO2dkBPpkSFl7eOdm+Nt3VCr7eQnl1fz5OWTgKjWZ1aUHKJOS8xwebhQ0EHI6tnwOjOqM4ZidJjpk7WOThG0wwCg539QyakQejfNj/sKa+Exe81CTLU6tpVtiq3rn14m9B6Wm7mBeO9hsJdb5QGva4bWRzejjow8xuL9tIpsBdn1zkmwC+jrc7kjT6ni4b7c0Ck15A1Zerb68rT1uVQwuIX9BwyzCSPFNN3AFrC0rjEx0/ZBpqzVK+xkkEls6bo= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(10070799003)(23010399003)(376014)(366016)(1800799024)(4143699003)(56012099006)(22082099003)(18002099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bjVXUlBRV2tUbE9vMUZxTmFreGdlNFIvQm1HYnlaK0NIS0cvWnUrVXRxTWlV?= =?utf-8?B?M1pVYVVrMW5ZbXM3Sjh2VGxOMFNkdDNjOEFiZGxOK2x1bkRCMExaRGp6TCtR?= =?utf-8?B?dWY2T3lzQVd3aGJlRWRDdmJqczBQZzJ4YU5OQUl1ZitVc0kwSUJXVFlEZm9D?= =?utf-8?B?bjZEaERTVE1GVnhwTjIvcUtBd3VUVXM0L0xjUnpjTVVHQjNWempOVDRMOVhh?= =?utf-8?B?MElOWXVLaE9tQ0NOUm1pVk80azVzV2doV1pVTnAyOVNjUE9RZEVNaytLR1BO?= =?utf-8?B?d1VwQktmdzRSbzMvWGFLSnl3eWhEbERNMUFzYTVOMlZDYnJUUitlSTM4NnRO?= =?utf-8?B?bWxPMHFrY2dCT21YUWZRbzArdGpnRDhkSkY1YVZNVktWWHNob0FmaHV6VUE3?= =?utf-8?B?eWRRVjBzNVcrMmVzWE85Z2VTbC9lUFo3OEViU2UrWXFTbHorU1c4OXdXUHRj?= =?utf-8?B?UzBOYWJjd3IxajIyZDBtc1pmdnI3bUROQU1lZlFKcG9Qd3l5ZVBsV2Z5U2J2?= =?utf-8?B?czBPeGVCVm4wYU1nYktNNDd5TGtQYUI2dndCa1BweHdsTE42UjVxeTA1S1lu?= =?utf-8?B?OEI4VU0zRnhXcS9lR29hdktpNVh5MElJTXpDWHdzMyt4aThsSVorckl5Mkto?= =?utf-8?B?MnUyTVF0K2I4aG5CZTRrRnZHNjE0c0gvdkticm9ETENNa29ueDhOeVZUc0ov?= =?utf-8?B?eGc4dzN5NDFoN1NzbXVLckxhUHAxV2g2b3UxZHloZXVZTElaOHNiNHgyME5h?= =?utf-8?B?a20zWHBDQnpZZjB2RGxwT0JnT2t3Zzl3b0hHZGxrbjVXWHhMSzUzQnh3QU45?= =?utf-8?B?amVyenJSVVBWd0txb2t4MVE1NG5ucGR4c0VvY3ArNVV1dW1jancxYnZvV2ha?= =?utf-8?B?NWF3UVE1TFRyUkErY0ltSmdUaGNrTnAybHcrZnM2UUlmc3J3ODg2RkllZ0dD?= =?utf-8?B?QlI0Z24wZnhKZjdYWFRaRHhoOHFuSWpNWlpTaXFjYkFKWldqQmRzTnZDWVhM?= =?utf-8?B?VkJsbDNpdVZ6ekVqQmZuUTJQR3JNTVg0OHFTM1dtNXpmMFNLS0dxS2lsNnQz?= =?utf-8?B?M3hlMnFoWEkyTE5VZzY0blpyV0NtZWZZaVNXamhQTmtKT2VxNnVvK3BrMUlo?= =?utf-8?B?bFhUbGEyYU80RTJRM0IzRlVjMmgvclF2YTlTRnU0VlJJcjhQSExmU1RiNnlR?= =?utf-8?B?VnJ1c3FVWEIxVmZwdWZ3Z2RoYkQvQXlqd2NCcVM3ZWtzNkM5RkNwSjRKQ0c2?= =?utf-8?B?MUNERk5NTzV1Y0QyWVBqZlkwSGlBUEZiUUFvUDlYMEp0bzRuM25aVDRZbDlp?= =?utf-8?B?d3hKWFFFV1E2QUN0NXdJWFRWdUhFUXF3MGRyZEpDWEM1anB3QzVVMTFXWXB6?= =?utf-8?B?TkFIT3FZUE9McnNkNzhTRTA1OUVhMkJ1bnQ5dEZ4djRmZDkrNExRc1NkZnox?= =?utf-8?B?b1JQVWdXeTJvU1MrZWVmS2dPNXdqZ2hqOWpNNHJWemdNUlg3OFgyN09JNnUw?= =?utf-8?B?ZVBodVhYYTE5SGZxcjJVd21FSFFrS1kzR3dRSEJYemk0bEJPWHBKalZwM1Vo?= =?utf-8?B?QXdJWVdBYXBBWDFzalRseXhmcC9oWmQ5N0t6L1gvbGY5WlhIcG1TNjgxQW54?= =?utf-8?B?RTZMODVFWjNwRmRuQnF0bjM1OVhPK0VkRk1welVxV1lNc2dnQktzS25ueUJB?= =?utf-8?B?b001byswK2s5RHBRclpPRUVXQ2R2NlFoQldiSkRBb0laTWxnS2lHRUJNZFVr?= =?utf-8?B?VXRxYy8yT0hyeXZNM0kyVmhwNEZDQmVnejgvV0x6SlluUENEM0V5d2Y1aDlN?= =?utf-8?B?VlV2cUtuTVlVRFh0NFZSL1NVckg5bjIzUVg2Wi82cENRSFNERG5tdnV1bDg0?= =?utf-8?B?cGlKcjhOSGZYaTcrTjVqbG9qSWlXWjU2bG8yNmNtRys3eXl3dlIyUWNkc3FI?= =?utf-8?B?d043bC9jY2szcWFLVWZta2FxbURtVzd4OFJQWmJIRjFSb1hHeU04cjgvUThX?= =?utf-8?B?Qi9PbVJ5Y3dkTHhneGJwS21rT25mQUZ6NHViWXFmOTFjTkswM3p5bjJzaTNY?= =?utf-8?B?blpPTHpJNjVmMWgvMGd1S2ZnVm9XWVlHMzVpWTV1K05Ea3ZBanJsUGprejNY?= =?utf-8?B?ZW5VYzA0eTBnbHNjTDlsbmtqTitnNzdWM0xaaktSYXgrVmRwckF1Vk5XNnM2?= =?utf-8?B?b09yR0w3Rk01T3FSV0JqMm5BWUdYZGF3d0Q4VHRyTHFiVUo2Y3JqdS9TQ2x2?= =?utf-8?B?Q3JjeXpOblJpYWhZTS95QnFaNW00VndMYlplZWI5WHBPcTlzckViN2V3bStT?= =?utf-8?B?WGc3bjA4NVdrRkdwYUQ1bDVMUndUaGRCR3JVZ2Mzc01HMEc5Z1FUU2NCQW9q?= =?utf-8?Q?2QBpkItvNN26ATyvAV7Y1kPnTfV8Lky/EGyPYo9hmcOH3?= X-MS-Exchange-AntiSpam-MessageData-1: UpYgUU294+7kTA== X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 841453ee-903a-4301-0086-08dedc596bf3 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2026 18:56:15.7753 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6yG+uEoADSn4NtZoL96CIPGtQD0Dzf50Z7Mq84G3iOJD09X6YDmUH0SIo2rMMqViTXKSRtUnkXRcHI2Xgz3CIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT1PPF35D7F4F9F X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 7/7/26 2:54 PM, Guinevere Larsen wrote: > On 7/6/26 1:40 PM, Simon Marchi wrote: >> record_full_arch_list_add moves its `rec` argument, so it should take an >> rvalue ref to reflect that. Otherwise the fact that the object is moved >> from can be a "surprise" to the callers. >> >> Change-Id: Ibeb56b1523ad8aee077d3bc3cad1f00d6b47ea2f >> --- > > Yeah, this makes sense, and feels pretty straightforward > > Approved-By: Guinevere Larsen Thanks, pushed. Simon