Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Gary Benson <gbenson@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Do not manipulate "target:" filenames as local paths
Date: Fri, 24 Apr 2015 19:16:00 -0000	[thread overview]
Message-ID: <21818.38520.332957.849560@ruffy2.mtv.corp.google.com> (raw)
In-Reply-To: <1429085001-25894-1-git-send-email-gbenson@redhat.com>

Gary Benson writes:
 > Hi all,
 > 
 > This patch alters two places that manipulate object file filenames
 > to detect "target:" filenames and to not attempt to manipulate them
 > as paths on the local filesystem:
 > 
 >  - allocate_objfile is updated to not attempt to expand "target:"
 >    filenames with gdb_abspath.
 > 
 >  - load_auto_scripts_for_objfile is updated to not attempt to load
 >    auto-load scripts for object files with "target:" filenames.
 > 
 > Built and regtested on RHEL6.6 x86_64.
 > 
 > Ok to commit?
 > 
 > Cheers,
 > Gary
 > 
 > 
 > gdb/ChangeLog:
 > 
 > 	* objfiles.c (allocate_objfile): Do not attempt to expand name
 > 	if name is a "target:" filename.
 > 	* auto-load.c (load_auto_scripts_for_objfile): Do not attempt
 > 	to load auto-load scripts for objfiles with "target:" filenames.

Thanks for the ping.

LGTM.


  parent reply	other threads:[~2015-04-24 19:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-13 19:07 [PATCH] Mark object files with "target:" filenames as OBJF_NONLOCAL_FILENAME Gary Benson
2015-04-13 23:27 ` Doug Evans
2015-04-14 11:41   ` Gary Benson
2015-04-14 16:52     ` Doug Evans
2015-04-14 21:30       ` Gary Benson
2015-04-15  8:03     ` [PATCH v2] Do not manipulate "target:" filenames as local paths Gary Benson
2015-04-23 21:22       ` [PING][PATCH " Gary Benson
2015-04-24 19:16       ` Doug Evans [this message]
2015-04-27 14:42         ` [PATCH " Gary Benson
2015-04-15  8:56   ` [PATCH] Mark object files with "target:" filenames as OBJF_NONLOCAL_FILENAME Pedro Alves
2015-04-15 12:09     ` Gary Benson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=21818.38520.332957.849560@ruffy2.mtv.corp.google.com \
    --to=dje@google.com \
    --cc=gbenson@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox