From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107932 invoked by alias); 24 Apr 2015 19:16:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107922 invoked by uid 89); 24 Apr 2015 19:16:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ie0-f201.google.com Received: from mail-ie0-f201.google.com (HELO mail-ie0-f201.google.com) (209.85.223.201) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 24 Apr 2015 19:16:12 +0000 Received: by ierx19 with SMTP id x19so7354372ier.1 for ; Fri, 24 Apr 2015 12:16:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=I5l6HjM1JmuP+x5sG6umh462ONzmmLecj9VMywVSRWs=; b=UdZ9ZTbUaeChmOilnYIcscTCD58IZiZVq9quWz3vnVxJupi6MNPJmrV6FA/9vUrjX9 zmbqpa01eXzJPNVdCTWvW8myIBb/pdB6OeFJTqDbpQ+IgkMrkZnFG4hkKJfjv6k5t6mh T0Cmxzf7c0NVUNVIr0VLxASln2KQ7pIzE0QMfD5PFhN7rFQCV6XqvEAnfHG5RzSdnjG1 iEQMRyuQGrll9jSDzCbYrYcHunDu8R9Hb1MyI+VxMkQNHljjnvh01tiF3MPaZDkxFxJg cXaqq78bIMkOvAXJormOgReaFRJbYxRkozEZMtpl3/H6oYWatVOEamIjRWuIiqLu6WT0 BZgQ== X-Gm-Message-State: ALoCoQkotuhcaNTfzAqAzgBROxelIN/MvubKNrkgWipFwQ7/OxWKHfJmBATxxG4XllTV++N3Om40BU4mlJR425z9S8pHRBphl5dDL+NDKj45mwegX4rWm1DUY5dviXx6sbn95+A76bAps074HT/DEN91J/7wrB2Nom8wjPV1ruoXdHuThP+9DhQ= X-Received: by 10.182.114.168 with SMTP id jh8mr13557634obb.28.1429902969685; Fri, 24 Apr 2015 12:16:09 -0700 (PDT) Received: from corpmail-nozzle1-2.hot.corp.google.com ([100.108.1.103]) by gmr-mx.google.com with ESMTPS id t38si699802yhp.4.2015.04.24.12.16.09 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Apr 2015 12:16:09 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com ([172.17.128.107]) by corpmail-nozzle1-2.hot.corp.google.com with ESMTP id 0gX1zKtj.1; Fri, 24 Apr 2015 12:16:09 -0700 From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21818.38520.332957.849560@ruffy2.mtv.corp.google.com> Date: Fri, 24 Apr 2015 19:16:00 -0000 To: Gary Benson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Do not manipulate "target:" filenames as local paths In-Reply-To: <1429085001-25894-1-git-send-email-gbenson@redhat.com> References: <20150414114129.GB4660@blade.nx> <1429085001-25894-1-git-send-email-gbenson@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00946.txt.bz2 Gary Benson writes: > Hi all, > > This patch alters two places that manipulate object file filenames > to detect "target:" filenames and to not attempt to manipulate them > as paths on the local filesystem: > > - allocate_objfile is updated to not attempt to expand "target:" > filenames with gdb_abspath. > > - load_auto_scripts_for_objfile is updated to not attempt to load > auto-load scripts for object files with "target:" filenames. > > Built and regtested on RHEL6.6 x86_64. > > Ok to commit? > > Cheers, > Gary > > > gdb/ChangeLog: > > * objfiles.c (allocate_objfile): Do not attempt to expand name > if name is a "target:" filename. > * auto-load.c (load_auto_scripts_for_objfile): Do not attempt > to load auto-load scripts for objfiles with "target:" filenames. Thanks for the ping. LGTM.