From: Doug Evans <dje@google.com>
To: Petr Machata <pmachata@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][V2] dwarf.exp: Allow generating a stub .debug_line section
Date: Mon, 30 Mar 2015 18:19:00 -0000 [thread overview]
Message-ID: <21785.37797.271814.469027@ruffy2.mtv.corp.google.com> (raw)
In-Reply-To: <87619mkpil.fsf@redhat.com>
Petr Machata writes:
> Hi there,
>
> this is second iteration of my .debug_line support for dwarf.exp DWARF
> assembler. Last time around I implemented it as a macro, and the
> request was to make it a first-class section. This is now implemented.
>
> As before, only minimal support for include and file name lists is
> added, so that DW_AT_decl_file references elsewhere in DWARF file work.
>
> Thoughts?
>
> Thanks,
> Petr
Hi.
Just one nit.
Otherwise LGTM.
> + if { "$label" != "" } {
> + $label:
> + }
Should this be:
if { "$label" != "" } {
_emit "$label:"
}
?
next prev parent reply other threads:[~2015-03-30 18:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 23:08 Petr Machata
2015-03-30 18:19 ` Doug Evans [this message]
2015-03-30 19:48 ` Petr Machata
2015-03-30 20:00 ` Doug Evans
2015-03-31 14:30 ` Petr Machata
-- strict thread matches above, loose matches on Subject: below --
2015-02-23 14:46 [PATCH V2] " Petr Machata
2015-02-23 23:21 ` Yao Qi
2015-02-24 0:07 ` Petr Machata
2015-02-24 12:44 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21785.37797.271814.469027@ruffy2.mtv.corp.google.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=pmachata@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox