From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109812 invoked by alias); 30 Mar 2015 18:19:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109782 invoked by uid 89); 30 Mar 2015 18:19:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ie0-f201.google.com Received: from mail-ie0-f201.google.com (HELO mail-ie0-f201.google.com) (209.85.223.201) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 30 Mar 2015 18:19:20 +0000 Received: by iebtr6 with SMTP id tr6so3831957ieb.0 for ; Mon, 30 Mar 2015 11:19:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=DpTGIEoVVKMWLu1dqH9RUkTYQjNNp30P6kqYGhHaWjM=; b=G5MKowREWUCgS62ignkgXk3X4GywzLlbhkV/piN3tYIsvp0ipGNswLzI66lyd5l2wy K88HlZH8G6HvnrW08HGIvVOXgSeLE7Ik8Dl2Tb88g6xRXUJRzmy2HyzBlVkg1BiGjPTx Y/GVTw6gOU+oTZtNw4BuWKGD7KbRtC8ZkJmW5PFrCQOUl2gf4C9Ss/J9fK9wn5Ljb/Xw wPlmiCQEnut0DeDST6UIZF4BUQs2lNtSgdZvmVqwhdcnqvjiNnTYxHWMzRtN3lTFNx1l hvO7no5vN/r+vML6dis4O56tVrHvLxjhJZ7FFW8gA8IyAiW6rtq9IkA/EMzm4Tz9WoWh iESg== X-Gm-Message-State: ALoCoQkXOLXNKsnUtSGA3UHVIZgU5LxN5J4wcLikiKyvo0sC+XTpXezpIFp1GaEbbvjV7AVgBLCkM3Ov16W+KEa1j9W/d70ZlwVq7QY3HJxS9ZOPq5eIGmRRKmRfgY21EL/KwLhr3s53x0HAQZYDhK9kbNFPSUabYLtDEvb9WNcTunljzyaaBA4= X-Received: by 10.182.22.138 with SMTP id d10mr37802516obf.37.1427739558409; Mon, 30 Mar 2015 11:19:18 -0700 (PDT) Received: from corpmail-nozzle1-1.hot.corp.google.com ([100.108.1.104]) by gmr-mx.google.com with ESMTPS id 40si462637yho.6.2015.03.30.11.19.17 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Mar 2015 11:19:18 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com ([172.17.128.107]) by corpmail-nozzle1-1.hot.corp.google.com with ESMTP id iAC8cxbv.1; Mon, 30 Mar 2015 11:19:18 -0700 From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21785.37797.271814.469027@ruffy2.mtv.corp.google.com> Date: Mon, 30 Mar 2015 18:19:00 -0000 To: Petr Machata Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][V2] dwarf.exp: Allow generating a stub .debug_line section In-Reply-To: <87619mkpil.fsf@redhat.com> References: <87619mkpil.fsf@redhat.com> X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg01009.txt.bz2 Petr Machata writes: > Hi there, > > this is second iteration of my .debug_line support for dwarf.exp DWARF > assembler. Last time around I implemented it as a macro, and the > request was to make it a first-class section. This is now implemented. > > As before, only minimal support for include and file name lists is > added, so that DW_AT_decl_file references elsewhere in DWARF file work. > > Thoughts? > > Thanks, > Petr Hi. Just one nit. Otherwise LGTM. > + if { "$label" != "" } { > + $label: > + } Should this be: if { "$label" != "" } { _emit "$label:" } ?