From: Doug Evans <dje@google.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Remove dwarf_decode_lines argumewant_line_info
Date: Wed, 27 Aug 2014 18:59:00 -0000 [thread overview]
Message-ID: <21502.10872.260155.302338@ruffy2.mtv.corp.google.com> (raw)
In-Reply-To: <1409129366-14108-1-git-send-email-yao@codesourcery.com>
Yao Qi writes:
> Hi,
> dwarf_decode_lines is called in two functions,
> dwarf2_build_include_psymtabs and handle_DW_AT_stmt_list, in which, 1
> is passed to argument 'want_line_info' and 'want_line_info' is a
> conditional variable in dwarf_decode_lines. We can simplify it by
> removing 'want_line_info' and propagating the constant 1 into
> dwarf_decode_lines. This is what this patch does. This patch also
> remove one line comment about WANT_LINE_INFO in
> handle_DW_AT_stmt_list, as handle_DW_AT_stmt_list doesn't have such
> argument.
>
> gdb:
>
> 2014-08-27 Yao Qi <yao@codesourcery.com>
>
> * dwarf2read.c (dwarf_decode_lines): Update declaration.
> (handle_DW_AT_stmt_list): Remove comment about WANT_LINE_INFO.
> (dwarf_decode_lines): Remove argument
> want_line_info. Remove condition check on want_line_info.
> Callers update.
LGTM.
Thanks!
next prev parent reply other threads:[~2014-08-27 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 8:53 Yao Qi
2014-08-27 18:59 ` Doug Evans [this message]
2014-08-28 7:15 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21502.10872.260155.302338@ruffy2.mtv.corp.google.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox