From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31128 invoked by alias); 27 Aug 2014 18:59:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31112 invoked by uid 89); 27 Aug 2014 18:59:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ie0-f201.google.com Received: from mail-ie0-f201.google.com (HELO mail-ie0-f201.google.com) (209.85.223.201) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 27 Aug 2014 18:59:07 +0000 Received: by mail-ie0-f201.google.com with SMTP id tr6so111683ieb.4 for ; Wed, 27 Aug 2014 11:59:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=Hlx6SHiWJH98rumpS7TofbmbzNkTAdbDn2D/vV6VRJw=; b=Ueps5MWbG2Vz36kcKmc0hsehXD8jUyDQzYUEGSGSF3in2ijy4vpiBzInP0U9b4anoS 8w8iJrtO9cKBiyyHLsLbOZVSV7v1+g4IzP+sKEuIcJhO/sfh9Rlw6/hf3hvRQoRNTnXj oFD/59NPDh/85TLeqNJx4aH0Wn0EDECi6v1uFo1jWDcGAEoBRKn5qrPcKd0kl8VAZQdY Waxbg0qo+e6gNZm9C2QQOI+cWcNAMOFrmEhPIL7XKNJalzKYoT4zqoNcfo8XQTtMTfIR k7IQdEcF5SHv+6imhMovWcWwYWMRjKIsxLABoKqyQFX88JnuDIA6st+yFX8dPqCHzxpa T+3A== X-Gm-Message-State: ALoCoQkyiwVjdOMlwr9Lhl9e6ryvjZFTJj6O6gTV7waHqpMhZSS2bWEuh2N8V3TWlHP+aLOb722b X-Received: by 10.42.197.69 with SMTP id ej5mr2420509icb.7.1409165945437; Wed, 27 Aug 2014 11:59:05 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id h24si84095yhb.6.2014.08.27.11.59.05 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 27 Aug 2014 11:59:05 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com (ruffy2.mtv.corp.google.com [172.17.128.107]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id CDAAE31C2B4; Wed, 27 Aug 2014 11:59:04 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21502.10872.260155.302338@ruffy2.mtv.corp.google.com> Date: Wed, 27 Aug 2014 18:59:00 -0000 To: Yao Qi Cc: Subject: Re: [PATCH] Remove dwarf_decode_lines argumewant_line_info In-Reply-To: <1409129366-14108-1-git-send-email-yao@codesourcery.com> References: <1409129366-14108-1-git-send-email-yao@codesourcery.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00588.txt.bz2 Yao Qi writes: > Hi, > dwarf_decode_lines is called in two functions, > dwarf2_build_include_psymtabs and handle_DW_AT_stmt_list, in which, 1 > is passed to argument 'want_line_info' and 'want_line_info' is a > conditional variable in dwarf_decode_lines. We can simplify it by > removing 'want_line_info' and propagating the constant 1 into > dwarf_decode_lines. This is what this patch does. This patch also > remove one line comment about WANT_LINE_INFO in > handle_DW_AT_stmt_list, as handle_DW_AT_stmt_list doesn't have such > argument. > > gdb: > > 2014-08-27 Yao Qi > > * dwarf2read.c (dwarf_decode_lines): Update declaration. > (handle_DW_AT_stmt_list): Remove comment about WANT_LINE_INFO. > (dwarf_decode_lines): Remove argument > want_line_info. Remove condition check on want_line_info. > Callers update. LGTM. Thanks!