From: Doug Evans <dje@google.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH OBV] set print symbol off in py-value.exp and scm-value.exp
Date: Fri, 22 Aug 2014 17:07:00 -0000 [thread overview]
Message-ID: <21495.30949.160263.520544@ruffy2.mtv.corp.google.com> (raw)
In-Reply-To: <1408714136-32131-1-git-send-email-yao@codesourcery.com>
Yao Qi writes:
> 2014-08-22 Yao Qi <yao@codesourcery.com>
>
> * gdb.guile/scm-value.exp (test_lazy_strings): Set print
> symbol off.
> * gdb.python/py-value.exp (test_lazy_strings): Likewise.
> ---
> gdb/testsuite/gdb.guile/scm-value.exp | 2 ++
> gdb/testsuite/gdb.python/py-value.exp | 4 ++++
> 2 files changed, 6 insertions(+)
>
> diff --git a/gdb/testsuite/gdb.guile/scm-value.exp b/gdb/testsuite/gdb.guile/scm-value.exp
> index 91e1a56..3641f75 100644
> --- a/gdb/testsuite/gdb.guile/scm-value.exp
> +++ b/gdb/testsuite/gdb.guile/scm-value.exp
> @@ -219,6 +219,8 @@ proc test_lazy_strings {} {
> "= const char \*." "Test lazy-string type name equality"
> gdb_test "gu (print (value-type sptr))" \
> "= const char \*." "Test string type name equality"
> + # Prevent symbol on address 0x0 being printed.
> + gdb_test_no_output "set print symbol off"
> gdb_test "print sn" "0x0"
> gdb_scm_test_silent_cmd "gu (define snptr (history-ref 0))" \
> "lazy strings: get snptr value from history"
> diff --git a/gdb/testsuite/gdb.python/py-value.exp b/gdb/testsuite/gdb.python/py-value.exp
> index 0728266..0d18bef 100644
> --- a/gdb/testsuite/gdb.python/py-value.exp
> +++ b/gdb/testsuite/gdb.python/py-value.exp
> @@ -302,7 +302,11 @@ proc test_lazy_strings {} {
> gdb_py_test_silent_cmd "python lstr = sptr.lazy_string()" "Aquire lazy string" 1
> gdb_test "python print (lstr.type)" "const char \*." "Test lazy-string type name equality"
> gdb_test "python print (sptr.type)" "const char \*." "Test string type name equality"
> +
> + # Prevent symbol on address 0x0 being printed.
> + gdb_test_no_output "set print symbol off"
> gdb_test "print sn" "0x0"
> +
> gdb_py_test_silent_cmd "python snptr = gdb.history (0)" "Get value from history" 1
> gdb_test "python snstr = snptr.lazy_string(length=5)" ".*Cannot create a lazy string with address.*" "Test lazy string"
> gdb_py_test_silent_cmd "python snstr = snptr.lazy_string(length=0)" "Succesfully create a lazy string" 1
Nit.
I like the blank lines added in py-value.exp.
I also like consistency. :-)
Please add them to scm-value.exp too.
next prev parent reply other threads:[~2014-08-22 17:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 13:33 Yao Qi
2014-08-22 17:07 ` Doug Evans [this message]
2014-08-24 12:30 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21495.30949.160263.520544@ruffy2.mtv.corp.google.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox