From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8623 invoked by alias); 22 Aug 2014 17:07:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8607 invoked by uid 89); 22 Aug 2014 17:07:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f74.google.com Received: from mail-pa0-f74.google.com (HELO mail-pa0-f74.google.com) (209.85.220.74) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 22 Aug 2014 17:07:52 +0000 Received: by mail-pa0-f74.google.com with SMTP id lj1so2942457pab.1 for ; Fri, 22 Aug 2014 10:07:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=5D2bimKnmpFo8BQmpoz4jotwnV2Xjmvm5ROZVC45J6s=; b=mrZk8lhrvwqIjVGZIiFeJb3e/ia0hSnyFvzGtkReSSyfIJp/GJQbOfaEydyuvx+Zmw 1bWncTqtSqjxD9BIQDGvlHXiqqxcmv0I/vhEsktrEla5xxCJraXrDARsdzhBZuVZLPfv YZAZ9D6qtMAn7a5HtU4+s+lfDX5NQJrbXbha05gxjX5z+iYv+kcZ4gfSczdCqas0Bw7H fMi8zhIvEXXygpkKkM5AAkcv578Jcl6nh7rVpQHlpekjHBfP6N9ub7oRNSEZXUro75Ri yRvQeu70QuYQpnCKsKnxOlGBrwvWr76VFqkjSZhTvQr4PDomKn2wIKQqac7lWhypGQL8 XGXQ== X-Gm-Message-State: ALoCoQmUB0uuTmdE/82PkRpJEzeWii+SqS4v+bu4pKKDoLlA1XnTTD4uDzThdknfXngMEWp+KZRW X-Received: by 10.66.121.129 with SMTP id lk1mr1779561pab.16.1408727270266; Fri, 22 Aug 2014 10:07:50 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id f44si336829yhf.1.2014.08.22.10.07.50 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 22 Aug 2014 10:07:50 -0700 (PDT) Received: from ruffy2.mtv.corp.google.com (ruffy2.mtv.corp.google.com [172.17.128.107]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id AE99F31C341; Fri, 22 Aug 2014 10:07:49 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21495.30949.160263.520544@ruffy2.mtv.corp.google.com> Date: Fri, 22 Aug 2014 17:07:00 -0000 To: Yao Qi Cc: Subject: Re: [PATCH OBV] set print symbol off in py-value.exp and scm-value.exp In-Reply-To: <1408714136-32131-1-git-send-email-yao@codesourcery.com> References: <1408714136-32131-1-git-send-email-yao@codesourcery.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00502.txt.bz2 Yao Qi writes: > 2014-08-22 Yao Qi > > * gdb.guile/scm-value.exp (test_lazy_strings): Set print > symbol off. > * gdb.python/py-value.exp (test_lazy_strings): Likewise. > --- > gdb/testsuite/gdb.guile/scm-value.exp | 2 ++ > gdb/testsuite/gdb.python/py-value.exp | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/gdb/testsuite/gdb.guile/scm-value.exp b/gdb/testsuite/gdb.guile/scm-value.exp > index 91e1a56..3641f75 100644 > --- a/gdb/testsuite/gdb.guile/scm-value.exp > +++ b/gdb/testsuite/gdb.guile/scm-value.exp > @@ -219,6 +219,8 @@ proc test_lazy_strings {} { > "= const char \*." "Test lazy-string type name equality" > gdb_test "gu (print (value-type sptr))" \ > "= const char \*." "Test string type name equality" > + # Prevent symbol on address 0x0 being printed. > + gdb_test_no_output "set print symbol off" > gdb_test "print sn" "0x0" > gdb_scm_test_silent_cmd "gu (define snptr (history-ref 0))" \ > "lazy strings: get snptr value from history" > diff --git a/gdb/testsuite/gdb.python/py-value.exp b/gdb/testsuite/gdb.python/py-value.exp > index 0728266..0d18bef 100644 > --- a/gdb/testsuite/gdb.python/py-value.exp > +++ b/gdb/testsuite/gdb.python/py-value.exp > @@ -302,7 +302,11 @@ proc test_lazy_strings {} { > gdb_py_test_silent_cmd "python lstr = sptr.lazy_string()" "Aquire lazy string" 1 > gdb_test "python print (lstr.type)" "const char \*." "Test lazy-string type name equality" > gdb_test "python print (sptr.type)" "const char \*." "Test string type name equality" > + > + # Prevent symbol on address 0x0 being printed. > + gdb_test_no_output "set print symbol off" > gdb_test "print sn" "0x0" > + > gdb_py_test_silent_cmd "python snptr = gdb.history (0)" "Get value from history" 1 > gdb_test "python snstr = snptr.lazy_string(length=5)" ".*Cannot create a lazy string with address.*" "Test lazy string" > gdb_py_test_silent_cmd "python snstr = snptr.lazy_string(length=0)" "Succesfully create a lazy string" 1 Nit. I like the blank lines added in py-value.exp. I also like consistency. :-) Please add them to scm-value.exp too.