From: Doug Evans <dje@google.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 PR c++/17132] Add new argument NOSIDE to find_overload_match
Date: Thu, 14 Aug 2014 22:38:00 -0000 [thread overview]
Message-ID: <21485.14942.101569.492555@ruffy.mtv.corp.google.com> (raw)
In-Reply-To: <CAGyQ6gzQUgPQz1fUXes7Z_q6nMx7XCGNK4kUrrNfqW+80Djezw@mail.gmail.com>
Siva Chandra writes:
> The attached patch has been updated per Doug's suggestions.
>
> Original post: https://sourceware.org/ml/gdb-patches/2014-07/msg00197.html
> Doug's review comments:
> https://sourceware.org/ml/gdb-patches/2014-08/msg00055.html
>
> ChangeLog:
>
> 2014-08-14 Siva Chandra Reddy <sivachandra@google.com>
>
> gdb/
>
> * eval.c: Update all calls to find_overload_match.
> * valarith.c: Likewise.
> (value_user_defined_cpp_op, value_user_defined_op): New
> argument NOSIDE. Update all callers.
> * valops.c (find_overload_match): New argument NOSIDE.
> * value.h (find_overload_match): Update signature.
>
> gdb/testsuite
>
> * gdb.cp/pr17132.cc: New file.
> * gdb.cp/pr17132.exp: New file.
LGTM
prev parent reply other threads:[~2014-08-14 22:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 13:42 Siva Chandra
2014-08-14 22:38 ` Doug Evans [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21485.14942.101569.492555@ruffy.mtv.corp.google.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=sivachandra@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox