From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12663 invoked by alias); 14 Aug 2014 22:38:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12652 invoked by uid 89); 14 Aug 2014 22:38:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ig0-f201.google.com Received: from mail-ig0-f201.google.com (HELO mail-ig0-f201.google.com) (209.85.213.201) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 14 Aug 2014 22:38:25 +0000 Received: by mail-ig0-f201.google.com with SMTP id h3so41907igd.2 for ; Thu, 14 Aug 2014 15:38:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=VmgOFBuaaqWBDqnwAVnZyZ17E4kbdIgmbH1DNLZ/R4g=; b=dGO176nnYe++HonPnuPwhieWILXXf/QyZ3vBGGSbtlXdkDMZOTKBHDuhrPn5bNN/Z9 h3zoRCNWIJ8VBraYnt49IzTq5pgerH8CuIFz4yEZxKMWX23WoRzoQMuefzfRMLSCnMi7 Tk7pVm1JecpMQ2Jb6B3LVkYjz2URobqUcfcjZlmVE7zI0qZf3FY/rSsGDbBKfVASPa8x iSZUBcmzorOtFHIcqd2yCtKc8iskUL1EP9SjtJeTX65tacK2TEGXtOFh6KSV5zUuv0se 4Pm73fLDgoJFCpXl8Z3GTaRdxhZKnsY8lOVp1a14e3isLRhtkkRwKYmRZrYWa/D7fAY2 2AYQ== X-Gm-Message-State: ALoCoQkE2skFgRMmHREmwNN+ZUwxmSRpJorE46zv1sZTrr/SzA+kkxaq/ZdUpw2QEqoIgODa0N2s X-Received: by 10.182.45.162 with SMTP id o2mr6766058obm.20.1408055903201; Thu, 14 Aug 2014 15:38:23 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id y50si468940yhk.4.2014.08.14.15.38.23 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 14 Aug 2014 15:38:23 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 9F2A831C323; Thu, 14 Aug 2014 15:38:22 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21485.14942.101569.492555@ruffy.mtv.corp.google.com> Date: Thu, 14 Aug 2014 22:38:00 -0000 To: Siva Chandra Cc: gdb-patches Subject: Re: [PATCH v2 PR c++/17132] Add new argument NOSIDE to find_overload_match In-Reply-To: References: X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00255.txt.bz2 Siva Chandra writes: > The attached patch has been updated per Doug's suggestions. > > Original post: https://sourceware.org/ml/gdb-patches/2014-07/msg00197.html > Doug's review comments: > https://sourceware.org/ml/gdb-patches/2014-08/msg00055.html > > ChangeLog: > > 2014-08-14 Siva Chandra Reddy > > gdb/ > > * eval.c: Update all calls to find_overload_match. > * valarith.c: Likewise. > (value_user_defined_cpp_op, value_user_defined_op): New > argument NOSIDE. Update all callers. > * valops.c (find_overload_match): New argument NOSIDE. > * value.h (find_overload_match): Update signature. > > gdb/testsuite > > * gdb.cp/pr17132.cc: New file. > * gdb.cp/pr17132.exp: New file. LGTM