From: "Eli Zaretskii" <eliz@is.elta.co.il>
To: jeffh@redhat.com
Cc: gdb-patches@sourceware.cygnus.com
Subject: Re: [RFA] fix gdb.base/remote.c for small int targets
Date: Fri, 31 Aug 2001 00:27:00 -0000 [thread overview]
Message-ID: <2110-Fri31Aug2001102556+0300-eliz@is.elta.co.il> (raw)
In-Reply-To: <Pine.SOL.3.91.1010830220552.25088t-100000@taarna.cygnus.com>
> Date: Thu, 30 Aug 2001 22:11:23 -0700 (PDT)
> From: Jeff Holcomb <jeffh@redhat.com>
>
> -#ifdef mc68hc11
> +#include <limits.h>
> +/* For targets with 16bit int, use a 1k buffer. */
> +#if INT_MAX < 32768
Shouldn't you use 32768L or 32768U? If an int is only 16 bits wide,
32768 might overflow into the sign bit, and then all bets are off.
next prev parent reply other threads:[~2001-08-31 0:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3B8EFA12.2010403@cygnus.com>
2001-08-30 22:11 ` Jeff Holcomb
2001-08-31 0:27 ` Eli Zaretskii [this message]
2001-08-31 8:29 ` Kevin Buettner
2001-08-31 9:01 ` Eli Zaretskii
2001-08-31 9:45 ` Kevin Buettner
2001-08-31 11:22 ` Eli Zaretskii
2001-08-31 8:30 ` Kevin Buettner
2001-09-03 12:55 ` [PATCH] " Jeff Holcomb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2110-Fri31Aug2001102556+0300-eliz@is.elta.co.il \
--to=eliz@is.elta.co.il \
--cc=gdb-patches@sourceware.cygnus.com \
--cc=jeffh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox