From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Eli Zaretskii" To: jeffh@redhat.com Cc: gdb-patches@sourceware.cygnus.com Subject: Re: [RFA] fix gdb.base/remote.c for small int targets Date: Fri, 31 Aug 2001 00:27:00 -0000 Message-id: <2110-Fri31Aug2001102556+0300-eliz@is.elta.co.il> References: X-SW-Source: 2001-08/msg00315.html > Date: Thu, 30 Aug 2001 22:11:23 -0700 (PDT) > From: Jeff Holcomb > > -#ifdef mc68hc11 > +#include > +/* For targets with 16bit int, use a 1k buffer. */ > +#if INT_MAX < 32768 Shouldn't you use 32768L or 32768U? If an int is only 16 bits wide, 32768 might overflow into the sign bit, and then all bets are off.